Remove JavaToolInstallerV0 tests dependencies #16657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the vulnerabilities - there is a problem only with |
added 2 commits
August 2, 2022 19:24
…-tasks into users/KonstantinTyukalov/JavaToolInstallerV0_bump_mocha
@vmapetr This npm definition in the tests directory is not needed for tests execution, may contain differences between dependencies of main task packages and may also contain vulnerabilities, which adds to the workload. I think a good option in this case would be to remove the npm definitions from tests |
vmapetr
approved these changes
Aug 2, 2022
alexander-smolyakov
approved these changes
Aug 3, 2022
AndreyIvanov42
approved these changes
Aug 3, 2022
mmrazik
approved these changes
Aug 3, 2022
KonstantinTyukalov
changed the title
4 tasks
KonstantinTyukalov
deleted the
users/KonstantinTyukalov/JavaToolInstallerV0_bump_mocha
branch
KonstantinTyukalov
restored the
users/KonstantinTyukalov/JavaToolInstallerV0_bump_mocha
branch
KonstantinTyukalov
deleted the
users/KonstantinTyukalov/JavaToolInstallerV0_bump_mocha
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: JavaToolInstallerV0
Description: Removed npm package definitions from tests suite because it's not used and contains vulnerabilities:
Also added useful scripts in task npm definition
Documentation changes required: N
Added unit tests: N
Attached related issue: N
Checklist: