AzureKeyVault task - Fix keyvault name format #16523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavloAndriiesh
approved these changes
Jul 4, 2022
|
Looks good to me |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
@simonasaitta the change you made doesn't seem to codify the exact requirements you linked? Would it be better to replace the check with a regex or is this sufficient? |
TomasHubelbauer
approved these changes
Jul 7, 2022
simonasaitta
added a commit
to simonasaitta/azure-pipelines-tasks
that referenced
this pull request
Jul 11, 2022
* Add error message in case of invalid key vault name * bump version Co-authored-by: Simona Saitta <[email protected]> Co-authored-by: Pavlo Andriiesh <[email protected]>
alexander-smolyakov
pushed a commit
that referenced
this pull request
Jul 11, 2022
* Add error message in case of invalid key vault name * bump version Co-authored-by: Simona Saitta <[email protected]> Co-authored-by: Pavlo Andriiesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureKeyVaultV2
Description: Throw an error in case of invalid characters in keyvault name
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) work item
Checklist: