Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stats function in the CopyFilesV2 task #16453

Merged
merged 15 commits into from
Jul 22, 2022
Merged

Fix stats function in the CopyFilesV2 task #16453

merged 15 commits into from
Jul 22, 2022

Conversation

DenisRumyantsev
Copy link
Contributor

@DenisRumyantsev DenisRumyantsev commented Jun 15, 2022 •
edited
Loading

Task name: CopyFilesV2

Description: this PR fixes the stats function and filtering out directories in the CopyFilesV2 task when an item can not be found. Previously, it was not taken into account that the stats function can return undefined, and in this case, an error occurred when filtering by directories: Cannot read property 'isDirectory' of undefined

Documentation changes required: No

Added unit tests: No

Related issue

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Risks analysis checklist:

  • There are no risky dependency updates
  • Changes have been tested
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • We understand how the task is working, how changes affect the task behavior
  • There are no breaking changes
  • There are no other concerns
  • I have not discovered any new uncovered test/use cases

@DenisRumyantsev DenisRumyantsev requested a review from a team as a code owner June 15, 2022 08:05
KonstantinTyukalov
KonstantinTyukalov approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this changes manually. LTGM, thanks! Could you check small comment?

@DenisRumyantsev DenisRumyantsev merged commit 01d5748 into master Jul 22, 2022
DenisRumyantsev added a commit that referenced this pull request Aug 10, 2022
@DenisRumyantsev
Revert "Fix stats function in the CopyFilesV2 task (#16453)"
7016575 
This reverts commit 01d5748.
@DenisRumyantsev DenisRumyantsev mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-smolyakov alexander-smolyakov alexander-smolyakov approved these changes

@vmapetr vmapetr vmapetr approved these changes

@KonstantinTyukalov KonstantinTyukalov KonstantinTyukalov approved these changes

@wojgasior wojgasior wojgasior approved these changes

@kirill-ivlev kirill-ivlev kirill-ivlev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DenisRumyantsev @alexander-smolyakov @vmapetr @KonstantinTyukalov @wojgasior @kirill-ivlev