Fixing hyperV container deployment for Azure App Service Deploy task #16367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please bump the task version as per the Checklist. |
|
Hi @PhilipsonJoseph, can you please take a look at this PR. |
mmrazik
reviewed
Jun 16, 2022
|
Hi @mmrazik - since there's no response on this from @PhilipsonJoseph, can you please proceed with approving the PR? |
|
Hi @@mmrazik - a gentle reminder to merge on this PR |
|
@SatishRanjan looks good from my end but you need to update your branch |
|
@geekzter - Hi Eric, updated this branch from master latest. |
|
/azp run |
|
@SatishRanjan sorry for missing this :( |
mmrazik
approved these changes
Jul 19, 2022
|
Azure Pipelines successfully started running 4 pipeline(s). |
alexander-smolyakov
approved these changes
Jul 20, 2022
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Hi @mmrazik and /or @alexander-smolyakov - with your approvals, request you to please merge this PR as I don't have write access to perform the merge operation. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: Azure App Service Deploy
Description: The changes are to enable deployment of windows container apps on the azure app services
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) NA
Attached related issue: (Y/N) ADO task https://msazure.visualstudio.com/Antares/_workitems/edit/9172309
Checklist: