Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GradleV3] Improve task failure message #16078

Merged
merged 8 commits into from
Apr 15, 2022
Merged

[GradleV3] Improve task failure message #16078

merged 8 commits into from
Apr 15, 2022

Conversation

alexander-smolyakov
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov commented Mar 28, 2022 •
edited
Loading

Task name: GradleV3

Description:
Improve task failure message to make it user-friendly

Changelog:

  • Improved task failure message
  • Moved helper functions to separate modules
  • Added interfaces
  • Resolved linter warnings
  • Updated linter settings
  • Added JSdoc to the functions

Documentation changes required: No

Added unit tests: No

Attached related issue:

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Improve Gradle codebase
4796ac0 
- Move helper functions to separate modules
- Add interfaces
- Resolve linter warnings
- Add JSdoc to the functions
- Improve task fail error message
@ghost
Copy link

ghost commented Mar 28, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@alexander-smolyakov alexander-smolyakov marked this pull request as ready for review April 1, 2022 13:47
@KonstantinTyukalov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

anatolybolshakov
anatolybolshakov approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KonstantinTyukalov KonstantinTyukalov self-requested a review April 6, 2022 10:08
KonstantinTyukalov
KonstantinTyukalov approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked these changes manually. LGTM, Thanks!

@alexander-smolyakov
Copy link
Contributor Author

Hey @mmrazik, could you please review and merge this pull request?

@KonstantinTyukalov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@KonstantinTyukalov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@KonstantinTyukalov KonstantinTyukalov merged commit 6fb15a2 into microsoft:master Apr 15, 2022
@alexander-smolyakov alexander-smolyakov deleted the users/alexander-smolyakov/issue3472_GradleV3_improve_task_failure_message branch April 15, 2022 11:46
@bannus bannus mentioned this pull request Jan 2, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmrazik mmrazik mmrazik approved these changes

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@EzzhevNikita EzzhevNikita EzzhevNikita approved these changes

@KonstantinTyukalov KonstantinTyukalov KonstantinTyukalov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexander-smolyakov @KonstantinTyukalov @mmrazik @anatolybolshakov @EzzhevNikita