Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JenkinsDownloadArtifacts migrate to Node10 #15954

Conversation

AndreyIvanov42
Copy link
Contributor

@AndreyIvanov42 AndreyIvanov42 commented Feb 22, 2022

Task name: JenkinsDownloadArtifactsV1

Description: Task migrate to node 10

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@AndreyIvanov42 AndreyIvanov42 requested a review from a team February 22, 2022 09:12
@AndreyIvanov42
Copy link
Contributor Author

tested only by unit test

@AndreyIvanov42
Copy link
Contributor Author

@geekzter

@AndreyIvanov42
Copy link
Contributor Author

@harshiniks would it be possible for you to test and review these changes - to make sure that it's all fine?

@harshiniks
Copy link
Contributor

@harshiniks would it be possible for you to test and review these changes - to make sure that it's all fine?

@v-nmursapall is handling this now. Can you please reach out to her?

@v-nmursapall
Copy link
Contributor

The code changes look fine to me.

@AndreyIvanov42
Copy link
Contributor Author

@harshiniks Could you approve the PR? I can't merge without approval from the code owner according to policy.

@AndreyIvanov42 AndreyIvanov42 merged commit 2a525c5 into microsoft:master Mar 31, 2022
@AndreyIvanov42 AndreyIvanov42 deleted the users/v-andivanov/jenkins-download-artifactsV1-migrate-node10 branch March 31, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants