Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate NuGetRestoreV1 task to Node10 #15855

Merged
merged 14 commits into from
Aug 2, 2022
Merged

Migrate NuGetRestoreV1 task to Node10 #15855

merged 14 commits into from
Aug 2, 2022

Conversation

mr-dokara
Copy link
Contributor

@mr-dokara mr-dokara commented Feb 1, 2022 •
edited
Loading

Task name: NuGetRestoreV1

Description: Migrated NuGetRestoreV1 task to Node10.

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped
  • Checked that applied changes work as expected

Test results:

  • Current canary tests for NuGet - results
  • Simple tests for NuGet restore - results

@mr-dokara mr-dokara changed the title Migrate NuGetRestoreV1 task to Node10 [Draft] Migrate NuGetRestoreV1 task to Node10 Feb 1, 2022
@mr-dokara mr-dokara changed the title [Draft] Migrate NuGetRestoreV1 task to Node10 Migrate NuGetRestoreV1 task to Node10 Feb 2, 2022
@mr-dokara mr-dokara requested a review from a team February 2, 2022 07:41
@mr-dokara mr-dokara mentioned this pull request Feb 2, 2022
Closed
39 tasks
@DaniilShmelev DaniilShmelev requested a review from a team February 2, 2022 07:55
@anatolybolshakov
Copy link
Contributor

@golubev-ivan could you please describe shortly which scenarios have you tested?

@mr-dokara
Copy link
Contributor Author

@golubev-ivan could you please describe shortly which scenarios have you tested?

I manually tested this task using a simple project without external packages.

@mr-dokara
Copy link
Contributor Author

cc @geekzter for visibility

@mr-dokara mr-dokara requested a review from mmrazik February 25, 2022 09:05
@mr-dokara
Copy link
Contributor Author

Hi @aasim, @phil-hodgson, Could you please take a look at this PR?

@mr-dokara mr-dokara requested a review from satbai as a code owner June 30, 2022 13:33
@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@DmitriiBobreshev
Copy link
Contributor

DmitriiBobreshev commented Jun 30, 2022 •
edited
Loading

Test results are here

Risks analysis checklist

  • There are no risky dependency updates
  • Changes have been tested
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • We understand how tasks are working, how changes affect task behavior
  • There are no breaking changes
  • There are no other concerns
  • I have not discovered any new uncovered test/use cases

@DmitriiBobreshev
Copy link
Contributor

DmitriiBobreshev commented Jul 6, 2022 •
edited
Loading

Hi @phil-hodgson, @aasim, @satbai Could you please take a look at this PR?

tintse-thxsky-MSFT
tintse-thxsky-MSFT requested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@tintse-thxsky-MSFT tintse-thxsky-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please look at the comment in package json

@mpodriezov
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tintse-thxsky-MSFT
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tintse-thxsky-MSFT
Copy link
Contributor

tintse-thxsky-MSFT commented Jul 28, 2022 •
edited by max-zaytsev
Loading

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@azure-pipelines
Copy link

Comment was made before the most recent commit for PR 15855 in repo microsoft/azure-pipelines-tasks

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@mpodriezov
Copy link
Contributor

mpodriezov commented Aug 1, 2022 •
edited by max-zaytsev
Loading

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@microsoft microsoft deleted a comment from azure-pipelines bot Aug 2, 2022
@tintse-thxsky-MSFT tintse-thxsky-MSFT merged commit bff7b37 into master Aug 2, 2022
@KonstantinTyukalov KonstantinTyukalov mentioned this pull request Aug 22, 2022
Closed
@tintse-thxsky-MSFT tintse-thxsky-MSFT deleted the users/golubev-ivan/migrate-nugetrestore-task-to-node10 branch October 24, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpodriezov mpodriezov mpodriezov left review comments

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@EzzhevNikita EzzhevNikita EzzhevNikita approved these changes

@vmapetr vmapetr vmapetr approved these changes

@DaniilShmelev DaniilShmelev DaniilShmelev approved these changes

@kirill-ivlev kirill-ivlev kirill-ivlev approved these changes

@tintse-thxsky-MSFT tintse-thxsky-MSFT tintse-thxsky-MSFT approved these changes

@aasim aasim Awaiting requested review from aasim

@phil-hodgson phil-hodgson Awaiting requested review from phil-hodgson

@mmrazik mmrazik Awaiting requested review from mmrazik

@satbai satbai Awaiting requested review from satbai

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mr-dokara @anatolybolshakov @DmitriiBobreshev @mpodriezov @tintse-thxsky-MSFT @EzzhevNikita @vmapetr @DaniilShmelev @kirill-ivlev