-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating to Node 16 #844
Migrating to Node 16 #844
Conversation
Migrated taskCopyFiles, UsePythonVersion, CMake Environment used (OS/Agent)Windows 10x64 / Agent with Node 16 handler, Ubuntu 16.04x64 / Agent with Node 16 handler, macOS 12 / Agent with Node 16 handler Test cases
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the comments below.
Also, please add a contribution section to the README.md
file in the follow-up pull request to describe the current workflow:
master
branch for SDK v3 (stable and targets Node10)releases/4.x
branch for SDK v4 (preview and targets Node16)- Changes that were merged for SDK v3 should be cherry-picked for SDK v4 once they are merged to the
master branch
916e343
to
379cb2a
Compare
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Konstantin Tyukalov <[email protected]>
…-task-lib into users/v-andivanov/release-4-node16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Migrating to Node 16 (#844) * create new release/4.x branch * release for 4 version * update pipeline * update package.json * fix test and build commands * fixed tests on node18 * change image version for linux * fix test for linux * add separete test for linux * node v16.13 * add v16.13.0 to test * test on windows-2022, macOS-11 * separate branch for node16 * remove temporary code * update package.json * changed pipeline * updated pipeline * Microsoft mandatory file (#839) * Update pipeline to include a step for publishing artifacts. (#848) (#849) * Update pipeline * Update azure-pipelines.yml * nodeversion as variable * Added node16 to schema (#852) Co-authored-by: Andrey Ivanov <[email protected]> * bump version (#862) Co-authored-by: Andrey Ivanov <[email protected]> * Update ci-cd for publishing npm package (#863) * fix npm publish Co-authored-by: Andrey Ivanov <[email protected]> * fix add registry (#864) Co-authored-by: Andrey Ivanov <[email protected]> * fix ToolRunner - _getSpawnSyncOptions (#873) * Mockery version is updated from 1.7.0 to 2.1.0 because of vulnerability (#878) * Fixed release path (#888) * Improvement of the release condition (#889) * Added test task with test condition. Negative test * Added test task with test condition. Positive test * Fix path * Fix path * Fix path * Changed build.sourcebranchname -> build.sourcebranch and path to branch * Fix path * Version changed (#894) * Pipeline fixing (#893) * Token test * Test token * Publish test * call order changed * Nmp token syntax reverted * Changed windows job * Script clearing * Uncommented condition * Token changed * Test - off publish condition * Switched on publish condition * Package version was reverted * Add escape for more correct working * Add changelog * Update package-lock version * Bump tl version to 4.1.0 * Update changelog * Remove PS task lib changes from node changelog * Update changelog for 4.0.1-preview Co-authored-by: AndreyIvanov42 <[email protected]> Co-authored-by: Andrey Ivanov <[email protected]> Co-authored-by: Denis Rumyantsev <[email protected]> Co-authored-by: Roman-Shchukin <[email protected]>
* Migrating to Node 16 (microsoft#844) * create new release/4.x branch * release for 4 version * update pipeline * update package.json * fix test and build commands * fixed tests on node18 * change image version for linux * fix test for linux * add separete test for linux * node v16.13 * add v16.13.0 to test * test on windows-2022, macOS-11 * separate branch for node16 * remove temporary code * update package.json * changed pipeline * updated pipeline * Microsoft mandatory file (microsoft#839) * Update pipeline to include a step for publishing artifacts. (microsoft#848) (microsoft#849) * Update pipeline * Update azure-pipelines.yml * nodeversion as variable * Added node16 to schema (microsoft#852) Co-authored-by: Andrey Ivanov <[email protected]> * bump version (microsoft#862) Co-authored-by: Andrey Ivanov <[email protected]> * Update ci-cd for publishing npm package (microsoft#863) * fix npm publish Co-authored-by: Andrey Ivanov <[email protected]> * fix add registry (microsoft#864) Co-authored-by: Andrey Ivanov <[email protected]> * fix ToolRunner - _getSpawnSyncOptions (microsoft#873) * Mockery version is updated from 1.7.0 to 2.1.0 because of vulnerability (microsoft#878) * Fixed release path (microsoft#888) * Improvement of the release condition (microsoft#889) * Added test task with test condition. Negative test * Added test task with test condition. Positive test * Fix path * Fix path * Fix path * Changed build.sourcebranchname -> build.sourcebranch and path to branch * Fix path * Version changed (microsoft#894) * Pipeline fixing (microsoft#893) * Token test * Test token * Publish test * call order changed * Nmp token syntax reverted * Changed windows job * Script clearing * Uncommented condition * Token changed * Test - off publish condition * Switched on publish condition * Package version was reverted * Add escape for more correct working * Add changelog * Update package-lock version * Bump tl version to 4.1.0 * Update changelog * Remove PS task lib changes from node changelog * Update changelog for 4.0.1-preview Co-authored-by: AndreyIvanov42 <[email protected]> Co-authored-by: Andrey Ivanov <[email protected]> Co-authored-by: Denis Rumyantsev <[email protected]> Co-authored-by: Roman-Shchukin <[email protected]>
Task description
In order to migrate tasks to the Node16 execution handler, we have to update the pipelines-task-lib itself to support the Node16 runtime.
Changelog
decipher.update
method callTesting
by unit-tests
manually as part of some task. Used tasks and cases are described here
Added unit tests: No