Fix documentation, comment and condition for getEndpointAuthorization function #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task lib version is not bumped |
ghost
approved these changes
Aug 31, 2021
anatolybolshakov
suggested changes
Aug 31, 2021
SimonAlling
suggested changes
Sep 1, 2021
anatolybolshakov
approved these changes
Sep 2, 2021
Co-authored-by: Simon Alling <[email protected]>
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
… function (microsoft#790) * fix doc, comment and condition * bumped version * bump version * fix documentation Co-authored-by: Anna Opareva <[email protected]> Co-authored-by: Simon Alling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix documentation, comment and condition for getEndpointAuthorization function
The condition was changed because aval has type string | undefined, so its value will probably never be null and it will be better to use !!aval for more strong verification, it will allow us to check the empty string also.
related issue #775