Skipping the file if it was not found (the CI is fixed) #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…777) Sometimes there are spontaneous issues when working with unc-paths, so retries have been added for them.
DenisRumyantsev
changed the title
max-zaytsev
reviewed
Jul 22, 2021
There was a problem hiding this comment.
@DenisRumyantsev As far as I understand these changes should fix CI, but looks the issue still persists.
@EzzhevNikita I have already tried to provide similar changes related to the same issue via this PR, but it broke the CI for Linux and macOS, so I had to revert it and made a new PR, the current one. For fixing the CI for Windows, there was created another separate issue. |
alexander-smolyakov
approved these changes
Jul 23, 2021
Co-authored-by: Alexander Smolyakov <[email protected]>
EzzhevNikita
approved these changes
Jul 23, 2021
max-zaytsev
approved these changes
Jul 23, 2021
max-zaytsev
reviewed
Jul 23, 2021
max-zaytsev
approved these changes
Jul 23, 2021
This was referenced Jul 27, 2021
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
A part of the code was taken out from the `find` function to the new `_getStats` function. A new field `skipMissingFiles` was added into the `findOptions` parameter. When it is true, the `find` function skips files that were not found during the `_getStats` function execution. Also, the `mocktests` timeout increased from 15 to 30 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: occasionally the
findfunction fails with the errorFailed find: ENOENT: no such file or directory. The reason is that thefs.lstatSyncmethod applies to a file that already was deleted. So we should check a file presence and skip it if it does not exist.Changelog:
node/task.ts— thefindfunction — a part of the code where the error occurs was taken out to the separate_getStatsfunction. A new fieldskipMissingFileswas added into thefindOptionsparameter. When it is true, thefindfunction skips files that are not found during the_getStatsfunction execution.Related issue