Mock stdline and errline #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashtagchris
approved these changes
Dec 9, 2018
hashtagchris
suggested changes
Dec 11, 2018
node/test/mocktests.ts
Outdated
| }) | ||
|
|
||
| it('Mock toolRunner returns correct output', async () => { | ||
| const expectedStdout = "atool output here" + os.EOL + "abc" + os.EOL + "junk"; |
There was a problem hiding this comment.
Wouldn't/shouldn't the real task runner emit a 'stdline' event for "junk"?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, and it does on close. Sorry, looks like my brain didn't quite get going this morning :)
hashtagchris
approved these changes
Dec 11, 2018
|
Is this change alone worthy of bumping the version number and publishing to the npm registry? |
I think this probably warrants a patch update. @bryanmacfarlane can we publish? |
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
* Mock stdline and errline * Responsd to feedback * Fix issue with displaying extra line * Don't ignore last line * Bump patch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #234 which was closed due to inactivity.
Fixes #227.