Using TestRunSystem while creating the TestRun #1637
Conversation
navin22
commented
Jun 22, 2018
navin22
commented
- TestRunSystem will be added as CustomTestField to test TestRunData if present.
- Used both during merge test results true/false.
- L0 for the same.
- Not modifying the custom TestRunTitle if there is only one test result file to be published.
- L0 for test run title scenarios.
… test case owner - Reading the testcase attribute from junit xml as the test case owner. - Earlier we were setting the context owner, build or the release woner as the owner of test case also. - So removing it as that's not correct.
- TestRunSystem will be added as CustomTestField to test TestRunData if present. - Used both during merge test results true/false. - L0 for the same.
…t file to be published. Added L0 for all the testruntitle scenarios.
| @@ -391,5 +400,6 @@ internal static class PublishTestResultsEventProperties | |||
| public static readonly string RunTitle = "runTitle"; | |||
| public static readonly string PublishRunAttachments = "publishRunAttachments"; | |||
| public static readonly string ResultFiles = "resultFiles"; | |||
| public static readonly string TestRunSystem = "testRunSystem"; | |||
There was a problem hiding this comment.
I thought it would be better and consistent if I follow like other properties.
There was a problem hiding this comment.
this is different from other as in this case this is predefined custom field.
There was a problem hiding this comment.
Yeah, makes sense. But here it's an even property which will be coming from node. So still having it as is. But when creating the field, having the right case, as you suggested.
| eventProperties.TryGetValue(PublishTestResultsEventProperties.TestRunSystem, out _testRunSystem); | ||
| if (_testRunSystem == null) | ||
| { | ||
| _testRunSystem = string.Empty; |
There was a problem hiding this comment.
default value should be VSTS instead of empty ? check with PM once.
There was a problem hiding this comment.
Yeah, but that will come from the caller vsts-task-lib api call. microsoft/azure-pipelines-task-lib#373
| @@ -236,7 +238,7 @@ private void ProcessPublishTestResultsCommand(IExecutionContext context, Diction | |||
| { | |||
| cancellationToken.ThrowIfCancellationRequested(); | |||
| string runName = null; | |||
| if (!string.IsNullOrWhiteSpace(_runTitle)) | |||
| if (!string.IsNullOrWhiteSpace(_runTitle) && resultFiles.Count > 1) | |||
There was a problem hiding this comment.
We were adding _{count} to the custom test run title when there's more than on file. So I am just avoiding it adding when there's only one file/run. Currently it's the case for VsTest.
