Skip to content

Commit

Permalink
Merge pull request #2219 from microsoft/task-nonProxyHosts
Browse files Browse the repository at this point in the history
#2209 parse nonProxyHosts
  • Loading branch information
Flanker32 authored Feb 21, 2023
2 parents 3917add + 00db69c commit 9a33f0f
Show file tree
Hide file tree
Showing 3 changed files with 81 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ public class AzureConfiguration {
private String proxyUsername;
private String proxyPassword;
@Nullable
private String nonProxyHosts;
@Nullable
private SSLContext sslContext;
private int pageSize = 99;
private List<String> documentsLabelFields = new ArrayList<>(DEFAULT_DOCUMENT_LABEL_FIELDS);
Expand All @@ -49,5 +51,6 @@ public void setProxyInfo(ProxyInfo proxy) {
this.setHttpProxyPort(proxy.getPort());
this.setProxyUsername(proxy.getUsername());
this.setProxyPassword(proxy.getPassword());
this.setNonProxyHosts(proxy.getNonProxyHosts());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import lombok.Getter;
import lombok.experimental.SuperBuilder;
import org.jetbrains.annotations.Nullable;

@SuperBuilder
@Getter
Expand All @@ -16,4 +17,6 @@ public class ProxyInfo {
private int port;
private String username;
private String password;
@Nullable
private String nonProxyHosts;
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@
import java.net.URI;
import java.util.Collections;
import java.util.List;
import java.util.Optional;
import java.util.StringJoiner;
import java.util.regex.Pattern;

import static java.util.regex.Pattern.quote;

public class ProxyManager {
private static final String PROPERTY_USE_SYSTEM_PROXY = "java.net.useSystemProxies";
Expand Down Expand Up @@ -68,6 +73,18 @@ public void applyProxy() {
ProxySelector.setDefault(new ProxySelector() {
@Override
public List<Proxy> select(URI uri) {
if (uri == null) {
throw new IllegalArgumentException("URI can't be null.");
}
String protocol = uri.getScheme();
String host = uri.getHost();
if (protocol == null || host == null) {
throw new IllegalArgumentException("protocol = "+protocol+" host = "+host);
}
if (shouldNotUseProxyFor(toPattern(Optional.ofNullable(config.getNonProxyHosts()).orElse(StringUtils.EMPTY)),
host.toLowerCase())) {
return Collections.singletonList(Proxy.NO_PROXY);
}
return Collections.singletonList(proxy);
}

Expand Down Expand Up @@ -118,13 +135,16 @@ private static ProxyInfo getProxyFromProgramArgument(String prefix) {
final String proxyPort = System.getProperty(prefix + ".proxyPort");
final String proxyUser = System.getProperty(prefix + ".proxyUser");
final String proxyPassword = System.getProperty(prefix + ".proxyPassword");
final String nonProxyHosts = System.getProperty(prefix + ".nonProxyHosts");

if (StringUtils.isNoneBlank(proxyHost, proxyPort) && NumberUtils.isCreatable(proxyPort)) {
return ProxyInfo.builder().source(String.format("${%s}", prefix + ".proxyHost"))
.host(proxyHost)
.port(Integer.parseInt(proxyPort))
.username(proxyUser)
.password(proxyPassword).build();
.password(proxyPassword)
.nonProxyHosts(nonProxyHosts)
.build();
}
return null;
}
Expand All @@ -149,4 +169,58 @@ private static ProxyInfo getSystemProxyInner() {
return null;
}

/**
* refer to {@link sun.net.spi.DefaultProxySelector}
* @return {@code true} if given this pattern for non-proxy hosts and this
* urlhost the proxy should NOT be used to access this urlhost
*/
private static boolean shouldNotUseProxyFor(Pattern pattern, String urlhost) {
if (pattern == null || urlhost.isEmpty()) {
return false;
}
boolean matches = pattern.matcher(urlhost).matches();
return matches;
}

/**
* refer to {@link sun.net.spi.DefaultProxySelector}
* @param mask non-null mask
* @return {@link java.util.regex.Pattern} corresponding to this mask
* or {@code null} in case mask should not match anything
*/
private static Pattern toPattern(String mask) {
boolean disjunctionEmpty = true;
StringJoiner joiner = new StringJoiner("|");
for (String disjunct : mask.split("\\|")) {
if (disjunct.isEmpty()) {
continue;
}
disjunctionEmpty = false;
String regex = disjunctToRegex(disjunct.toLowerCase());
joiner.add(regex);
}
return disjunctionEmpty ? null : Pattern.compile(joiner.toString());
}

/**
* refer to {@link sun.net.spi.DefaultProxySelector}
* @param disjunct non-null mask disjunct
* @return java regex string corresponding to this mask
*/
private static String disjunctToRegex(String disjunct) {
String regex;
if ("*".equals(disjunct)) {
regex = ".*";
} else if (disjunct.startsWith("*") && disjunct.endsWith("*")) {
regex = ".*" + quote(disjunct.substring(1, disjunct.length() - 1)) + ".*";
} else if (disjunct.startsWith("*")) {
regex = ".*" + quote(disjunct.substring(1));
} else if (disjunct.endsWith("*")) {
regex = quote(disjunct.substring(0, disjunct.length() - 1)) + ".*";
} else {
regex = quote(disjunct);
}
return regex;
}

}

0 comments on commit 9a33f0f

Please sign in to comment.