Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add dummy location data to conform to SARIF spec #988

Merged
merged 6 commits into from
May 22, 2023
+9,832 −695
Merged

fix: Add dummy location data to conform to SARIF spec #988

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02ff389
fix: Add dummy location to conform to SARIF spec
DaveTryon May 5, 2023
7e6baa1
fix: Add dummy location to conform to SARIF spec
DaveTryon May 5, 2023
87341d8
Remove startColumn and endColumn properties
DaveTryon May 9, 2023
bf4c588
Revert "Remove startColumn and endColumn properties"
DaveTryon May 9, 2023
dbb8381
Merge branch 'add-dummy-location' of https://github.com/DaveTryon/axe…
DaveTryon May 9, 2023
64cfcf5
Remove startColumn and endColumn properties
DaveTryon May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Add dummy location to conform to SARIF spec
@DaveTryon
DaveTryon committed May 5, 2023
commit 7e6baa10c48fd9e09492bf7763c8ed721519ad72
3 changes: 3 additions & 0 deletions src/axe-raw-sarif-converter.ts
View file
Original file line number Diff line number Diff line change
@@ -174,6 +174,9 @@ export class AxeRawSarifConverter {
physicalLocation: {
artifactLocation: getArtifactLocation(environmentData),
region: {
startLine: 1,
startColumn: 1,
endColumn: 1,
snippet: {
text: axeRawNodeResult.node.source,
},
3 changes: 3 additions & 0 deletions src/sarif-converter.ts
View file
Original file line number Diff line number Diff line change
@@ -176,6 +176,9 @@ export class SarifConverter {
physicalLocation: {
artifactLocation: getArtifactLocation(environmentData),
region: {
startLine: 1,
startColumn: 1,
endColumn: 1,
snippet: {
text: node.html,
},
Loading