Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use IntoFuture now that it's stable #252

Merged
merged 2 commits into from
Jan 25, 2023
Merged

use IntoFuture now that it's stable #252

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ceec2e
use IntoFuture now that it's stable
Jan 25, 2023
b7b10a0
Merge branch 'main' into use-stabilized-intofuture
demoray Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ homepage = "https://github.com/microsoft/avml"
repository = "https://github.com/microsoft/avml"
readme = "README.md"
edition = "2021"
rust-version = "1.64.0"

[features]
default = ["put", "blobstore"]
Expand Down
3 changes: 1 addition & 2 deletions src/upload/blobstore.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ impl BlobUploader {

let block_list = BlockList { blocks };

self.client.put_block_list(block_list).into_future().await?;
self.client.put_block_list(block_list).await?;

Ok(())
}
Expand Down Expand Up @@ -330,7 +330,6 @@ impl BlobUploader {
let result = client
.put_block(upload_chunk.id, upload_chunk.data)
.hash(hash)
.into_future()
.await;

// as soon as any error is seen (after retrying), bail out and stop other uploaders
Expand Down