Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check each feature works on it's own #251

Merged
merged 3 commits into from
Jan 25, 2023
Merged

check each feature works on it's own #251

merged 3 commits into from
Jan 25, 2023

Conversation

demoray
Copy link
Collaborator

@demoray demoray commented Jan 25, 2023

Ensure that the issue raised in #249 does not reoccur.

@demoray
Copy link
Collaborator Author

demoray commented Jan 25, 2023

Of note, this PR should fail until #250 is merged and this PR is rebased to include the change.

@demoray
Copy link
Collaborator Author

demoray commented Jan 25, 2023

Of note, this PR uses a feature exposed in cargo in 1.60. However, #252 bumps the cargo version beyond 1.60, which is why it's not bumped here.

@demoray demoray requested a review from mx00s January 25, 2023 16:19
Copy link

@mx00s mx00s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock!

@demoray demoray enabled auto-merge (squash) January 25, 2023 17:33
@demoray demoray merged commit c1fde99 into main Jan 25, 2023
@demoray demoray deleted the check-each-feature branch June 15, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants