Fix main provider flow to try other bearer token providers if exchang… #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvmd
reviewed
Nov 20, 2018
CredentialProvider.Microsoft/CredentialProviders/Vsts/BearerTokenProvider.cs
Outdated
Show resolved
Hide resolved
salvmd
reviewed
Nov 20, 2018
salvmd
reviewed
Nov 20, 2018
CredentialProvider.Microsoft/CredentialProviders/Vsts/VstsCredentialProvider.cs
Show resolved
Hide resolved
salvmd
approved these changes
Nov 20, 2018
…ing for a session token fails. Add exception handling to continue trying other bearer token providers if one throws.
zarenner
force-pushed
the
users/zarenner/fixFlow
branch
from
14b75a4 to
aac0bc3
Compare
satishkumaarponnusamy-zzz
approved these changes
Nov 20, 2018
| ILogger logger, | ||
| IAuthUtil authUtil, | ||
| IBearerTokenProvidersFactory bearerTokenProvidersFactory, | ||
| IAzureDevOpsSessionTokenFromBearerTokenProvider vstsSessionTokenProvider) |
There was a problem hiding this comment.
nit: azureDevOpsSessionTokenProvider
There was a problem hiding this comment.
Gonna leave this for now - was about to merge and there's still a few other VSTS's hanging around. Let's do a VSTS cleanup pass though as part of the next round of work here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing for a session token fails.
Add exception handling to continue trying other bearer token providers if one throws.