Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session token cache global lock doesn't work cross-platform #416

Closed
JohnSchmeichel opened this issue Jun 1, 2023 · 5 comments · Fixed by #470
Closed

Session token cache global lock doesn't work cross-platform #416

JohnSchmeichel opened this issue Jun 1, 2023 · 5 comments · Fixed by #470
Labels
bug Something isn't working

Comments

@JohnSchmeichel
Copy link
Member

As reported by microsoft/artifacts-keyring#59 the global lock used by the session token cache doesn't work cross-platform if there is contention on the cache file.
@JohnSchmeichel JohnSchmeichel mentioned this issue Jun 1, 2023
Closed
@JohnSchmeichel
Copy link
Member Author

This usage needs to be addressed:

artifacts-credprovider/CredentialProvider.Microsoft/Util/SessionTokenCache.cs

Line 47 in 9ccd66d

int index = WaitHandle.WaitAny(new WaitHandle[] { mutex, this.cancellationToken.WaitHandle }, -1);

Multiple wait handles that involve a named mutex are not supported cross-platform.

@JohnSchmeichel JohnSchmeichel added the bug Something isn't working label Jun 1, 2023
@github-actions
Copy link

This issue has had no activity in 90 days. Please comment if it is not actually stale.

@github-actions github-actions bot added the stale This hasn't had any recent activity label Aug 30, 2023
@JohnSchmeichel
Copy link
Member Author

Not stale

@JohnSchmeichel JohnSchmeichel removed the stale This hasn't had any recent activity label Aug 31, 2023
@github-actions GitHub Actions
Copy link

This issue has had no activity in 90 days. Please comment if it is not actually stale.

@github-actions github-actions bot added the stale This hasn't had any recent activity label Nov 30, 2023
@JohnSchmeichel
Copy link
Member Author

Not stale

@JohnSchmeichel JohnSchmeichel removed the stale This hasn't had any recent activity label Nov 30, 2023
@embetten embetten mentioned this issue Feb 6, 2024
Merged
embetten added a commit that referenced this issue Feb 7, 2024
@embetten
Enable cross platform session token cache global locking (#470)
3bdd257 
Bug fix #416 
- Move session token cache file lock to single wait handle.
- Add new session cache specific cancel message so the cancel message is
not printed twice.
- Pass cancellation token to credential request handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable cross platform session token cache global locking microsoft/artifacts-credprovider
1 participant
@JohnSchmeichel