Fix jest in TestApp #314
Merged
Fix jest in TestApp #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MatkovIvan, eslint is not happy with mocks in |
|
@MatkovIvan Let's wait #303 to do that and have test app point at mock files provided by SDK. |
MatkovIvan
force-pushed
the
fix/testapp-jest
branch
from
a7cc41b to
e116966
Compare
guperrot
suggested changes
May 19, 2018
| @@ -0,0 +1,9 @@ | |||
| const Crashes = jest.mock('appcenter-crashes'); | |||
There was a problem hiding this comment.
Please catch up with develop and remove those. Might need to revisit the PR entirely now that #303 is merged.
guperrot
suggested changes
May 21, 2018
There was a problem hiding this comment.
I have the following errors when running npm run test after running ./update-npm-packages.sh on this branch:
npm run test
> [email protected] test /Users/guperrot/git/appcenter-sdk-react-native/TestApp
> jest
RUNS __tests__/index.ios.js
RUNS __tests__/index.android.js
Test Suites: 0 of 2 total
Tests: 0 total
Snapshots: 0 total
console.error node_modules/react-native/Libraries/ReactNative/YellowBox.js:73
The above error occurred in the <AnimatedComponent> component:
in AnimatedComponent (created by Card)
in Card (created by Container)
in Container (created by CardStack)
in View (created by Component)
in Component (created by CardStack)
in View (created by Component)
in Component (created by CardStack)
in CardStack (created by Transitioner)
in View (created by Component)
in Component (created by Transitioner)
in Transitioner (created by CardStackTransitioner)
in CardStackTransitioner
in Unknown (created by Navigator)
in Navigator (created by NavigationContainer)
in NavigationContainer
Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.
console.error node_modules/react-native/Libraries/ReactNative/YellowBox.js:73
The above error occurred in the <AnimatedComponent> component:
in AnimatedComponent (created by Card)
in Card (created by Container)
in Container (created by CardStack)
in View (created by Component)
in Component (created by CardStack)
in View (created by Component)
in Component (created by CardStack)
in CardStack (created by Transitioner)
in View (created by Component)
in Component (created by Transitioner)
in Transitioner (created by CardStackTransitioner)
in CardStackTransitioner
FAIL __tests__/index.android.js (16.119s)
✕ renders correctly (218ms)
● renders correctly
TypeError: Cannot read property '__getValue' of undefined
at AnimatedComponent.render (node_modules/react-native/Libraries/Animated/src/createAnimatedComponent.js:154:9)
at finishClassComponent (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:3666:31)
at updateClassComponent (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:3643:12)
at beginWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:4017:16)
at performUnitOfWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6008:16)
at workLoop (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6072:26)
at Object.invokeGuardedCallback$1 (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1553:10)
at invokeGuardedCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1500:29)
at renderRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6150:7)
at performWorkOnRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6764:24)
FAIL __tests__/index.ios.js (16.134s)
✕ renders correctly (258ms)
● renders correctly
TypeError: Cannot read property '__getValue' of undefined
at AnimatedComponent.render (node_modules/react-native/Libraries/Animated/src/createAnimatedComponent.js:154:9)
at finishClassComponent (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:3666:31)
at updateClassComponent (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:3643:12)
at beginWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:4017:16)
at performUnitOfWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6008:16)
at workLoop (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6072:26)
at Object.invokeGuardedCallback$1 (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1553:10)
at invokeGuardedCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1500:29)
at renderRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6150:7)
at performWorkOnRoot (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6764:24)
Test Suites: 2 failed, 2 total
Tests: 2 failed, 2 total
Snapshots: 0 total
Time: 18.567s
guperrot
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.