Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network requests allowed API #1519

Merged
merged 42 commits into from
May 12, 2021
Merged

Add network requests allowed API #1519

merged 42 commits into from
May 12, 2021

Conversation

AnastasiaKubova
Copy link
Contributor

@AnastasiaKubova AnastasiaKubova commented Apr 23, 2021 •
edited by xabldint
Loading

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests if this modifies the Windows code?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
  • Has at least one reviewer tested the PR?

Description

Add API to block network requests.

Related PRs or issues

AB#85219
AB#85223

Anastasia Kubova added 21 commits April 19, 2021 12:53
Add new API to App Center SDK
599ca9f
Update android version
197affd
Update test apps
bc8316d
Rename methods
35bc6eb
Update test apps
f5ae576
Add block for network requests API
c41a16b
Update API for iOS
a576f53
Update tests
8fe2233
Resolve feedback
b72e2bb
Resolve feedback
865db40
Fix test
06c404f
Update changelog
05ace1a
Save block network requests state
a7630d0
Fix block network requests after adding the channel
ccaa275
Update test apps
f6fa627
Add user default values
390c635
Merge pull request #1517 from microsoft/feature/block-network-request…
24eaef4 
…s-windows

Add API to block network requests
Merge branch 'feature/block-network-requests' into feature/block-netw…
bea7fa4 
…ork-requests-xamarin

# Conflicts:
#	SDK/AppCenter/Microsoft.AppCenter.Shared/AppCenter.cs
Merge pull request #1518 from microsoft/feature/block-network-request…
f52ece4 
…s-xamarin

Add API to block network requests (Xamarin)
Fix test
552c70c
Update block network requests implementation
3ede877
MatkovIvan
MatkovIvan reviewed Apr 28, 2021
View reviewed changes
Apps/Contoso.Android.Puppet/Constants.cs Outdated Show resolved Hide resolved
Apps/Contoso.Android.Puppet/ModulePages/AppCenterFragment.cs Outdated Show resolved Hide resolved
Apps/Contoso.Android.Puppet/Resources/values/Strings.xml Outdated Show resolved Hide resolved
Apps/Contoso.Forms.Puppet/Contoso.Forms.Puppet/Constants.cs Outdated Show resolved Hide resolved
Apps/Contoso.iOS.Puppet/Constants.cs Outdated Show resolved Hide resolved
SDK/AppCenter/Microsoft.AppCenter.Windows.Shared/Channel/ChannelGroup.cs Outdated Show resolved Hide resolved
SDK/AppCenter/Microsoft.AppCenter.Windows.Shared/Ingestion/Http/IngestionDecorator.cs Outdated Show resolved Hide resolved
SDK/AppCenter/Microsoft.AppCenter.Windows.Shared/Ingestion/IIngestion.cs Outdated Show resolved Hide resolved
@MatkovIvan MatkovIvan merged commit 3ea78d1 into develop May 12, 2021
@MatkovIvan MatkovIvan deleted the feature/block-network-requests branch May 12, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamminroot Jamminroot Jamminroot left review comments

@DmitriyKirakosyan DmitriyKirakosyan DmitriyKirakosyan left review comments

@MatkovIvan MatkovIvan MatkovIvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnastasiaKubova @DmitriyKirakosyan @MatkovIvan @Jamminroot