Object selection models and plugins #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevcunnane
approved these changes
Sep 15, 2017
components/js/SlickGrid.ts
Outdated
| for (let plugin of this.plugins) { | ||
| this.registerPlugin(plugin); | ||
| if (typeof plugin === 'string') { |
There was a problem hiding this comment.
You don't need this if check anymore, correct? registerPlugin accepts the plugin whether it's a string or a plugin object, so you can get rid of this?
There was a problem hiding this comment.
I think its a bug in typescript, if I don't add a type check if complains string | object not assignable to string.
There was a problem hiding this comment.
I guess I could fix it by not overloading the function and instead just having the input as string | object
There was a problem hiding this comment.
Looks like its a bug that they couldn't find a good way to fix, so they said just workaround it via my solution about just using a union type instead of an overload microsoft/TypeScript#1805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to specific selection models and plugins via the objects themselves rather than through names and assuming they will be attached to the global Slick object.
Also adds mapping files for easier debugging.