Added QNN EP for ARM64 builds. #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not ready for review since the exported projects are not great yet... I'm not sure what to do there... |
nmetulev
reviewed
Nov 27, 2024
| @@ -23,7 +23,8 @@ public static ModelCompatibility GetModelCompatibility(ModelDetails modelDetails | |||
|
|
|||
| ModelCompatibilityState compatibility; | |||
| if (modelDetails.HardwareAccelerators.Contains(HardwareAccelerator.CPU) || | |||
| (modelDetails.HardwareAccelerators.Contains(HardwareAccelerator.DML) && modelDetails.SupportedOnQualcomm == true)) | |||
| (modelDetails.HardwareAccelerators.Contains(HardwareAccelerator.DML) && modelDetails.SupportedOnQualcomm == true) || | |||
There was a problem hiding this comment.
We should disable all DML models on Arm64
| { | ||
| Dictionary<string, string> options = new() | ||
| { | ||
| { "backend_path", "QnnHtp.dll" } |
There was a problem hiding this comment.
we should include the high performance kv here too
| @@ -18,7 +18,8 @@ | |||
| "Description": "This is an embedding model executed on the CPU or GPU", | |||
| "HardwareAccelerator": [ | |||
| "CPU", | |||
| "DML" | |||
| "DML", | |||
| "QNN" | |||
There was a problem hiding this comment.
we need to do some testing here before enabling the models for qnn - I'm seeing both the cpu and npu running which might mean the model is falling back to cpu and it's not optimized for qnn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.