Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update node in CI builds to 14.19.0 #5139

Merged
merged 1 commit into from
Feb 3, 2022
Merged

chore(deps): update node in CI builds to 14.19.0 #5139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ on:
- cron: '0 19 * * 0'

env:
NODE_VERSION: 14.17.0
# Keep this in sync with /pipeline/install-node-prerequisites.yaml
NODE_VERSION: 14.19.0

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion docs/building-web.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ This document describes how to build and test Accessibility Insights for Web (th

You will need the following tools installed:

- [Node](https://nodejs.org) >= 14.15.0 (check by running `node --version`) - This is the version being enforced on our builds
- [Node](https://nodejs.org) >= 14.19.0 (check by running `node --version`) - This is the version being enforced on our builds
- [Yarn](https://yarnpkg.com/getting-started/install) >= 1.22.10 (check by running `yarn --version`)
- Note: There is a [known name collision](https://github.com/yarnpkg/yarn/issues/673) between Yarn package manager and Hadoop YARN. If you have Hadoop YARN installed, replace `yarn` with `yarnpkg` in the commands below.
- **macOS only** [Xcode](https://wilsonmar.github.io/xcode/#XcodeInstall). This is needed when installing some dev dependencies (like spectron). After installing Xcode, run the following commands from a command terminal:
Expand Down
5 changes: 3 additions & 2 deletions pipeline/install-node-prerequisites.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
steps:
- task: NodeTool@0
inputs:
versionSpec: '14.15.0'
displayName: use node 14.15.0
# Keep this in sync with /.github/workflows/ci.yml
versionSpec: '14.19.0'
displayName: use node 14.19.0
timeoutInMinutes: 2

- script: npm install [email protected] -g
Expand Down