-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in GetExeNameFromFilePath #2268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmpurifoy
requested review from
sharath2727,
danielayala94,
hulumane and
David-Quero
March 15, 2022 19:18
ghost
added
the
needs-triage
label
Mar 15, 2022
/azp run |
jonwis
approved these changes
Mar 15, 2022
/azp run |
hulumane
reviewed
Mar 15, 2022
hulumane
approved these changes
Mar 15, 2022
/azp run |
DrusTheAxe
reviewed
Mar 15, 2022
Comment was made before the most recent commit for PR 2268 in repo microsoft/WindowsAppSDK |
2 similar comments
Comment was made before the most recent commit for PR 2268 in repo microsoft/WindowsAppSDK |
Comment was made before the most recent commit for PR 2268 in repo microsoft/WindowsAppSDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a case where the exe is not in a filepath in the registry but is a standalone exe. This fixes that scenario.