Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/sachinta/add microsoft internal telemetry nuget package config #2260

Conversation

sachintaMSFT
Copy link
Contributor

@sachintaMSFT sachintaMSFT commented Mar 14, 2022

  • Add microsoft internal telemetry nuget package config
  • Remove unnecessary inclusion of microsofttelemetry.h as <wil/traceloggingconfig.h> provides the same stub functionality from public WIL nuget package
  • Update search for WindowsAppSDK-VersionInfo.h header includes current directory as the build pipeline is updated to copy the file to installer project folder for it's inclusion.

Testing:
These changes have been tested by verifying the installer from the build pipeline is generating the telemetry events as expected.

NOTE: These changes will need to be pulled into 1.1-preview1 branch after it's merged to main.

@sachintaMSFT sachintaMSFT added bug Something isn't working area-Installer labels Mar 14, 2022
@sachintaMSFT sachintaMSFT added this to the 1.1 milestone Mar 14, 2022
@ghost ghost added the needs-triage label Mar 14, 2022
@sachintaMSFT
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@DrusTheAxe DrusTheAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments

installer/dev/tracelogging.h Show resolved Hide resolved
@sachintaMSFT sachintaMSFT merged commit 3cdf99b into main Mar 15, 2022
@sachintaMSFT sachintaMSFT deleted the user/sachinta/AddMicrosoftInternalTelemetryNugetPackageConfig branch March 15, 2022 02:54
sachintaMSFT added a commit that referenced this pull request Mar 15, 2022
…2260)

* Add Microsoft Internal Telemetry Nuget Packages Config file

* Remove unecessary inclusion of MicrosoftTelemetry.h public stub while wil\traceloggingconfig.h is already included

Co-authored-by: Santosh Chintalapati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Installer bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants