Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IoStatus.Information should not be set on cleanup/close. Appears to b… #854

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jeffbromberger
Copy link

IoStatus.Information should not be set on cleanup/close. Appears to be copy and paste from Create code.

@rodwiddowson
Copy link
Contributor

I’m AFI ATM, BUT I’ll observe that NTFS does set information in the CLEANUP path under circumstances I forget..

Also it’s probably a good idea to zero out information anyway.

(Ps. Hi Jeff!)

@jeffbromberger
Copy link
Author

Hi Rod!

Setting it to zero sounds good.

I'm quite interested in the notion that NTFS would set it to something purposeful. If this is indeed a field to be set then there is a separate documentation bug for the IRP_MJ_CLEANUP page. Fwiw, the CDFS sample doesn't appear to set it to anything (other than zeroing it on error in CdCompleteRequest). The WRK (admittedly super old) doesn't appear to even check the status, much less the information, on IRP_MJ_CLEANUP.

@JakobL-MSFT JakobL-MSFT deleted the branch microsoft:develop May 22, 2024 16:08
@JakobL-MSFT
Copy link
Contributor

I closed this PR unintentionally. I apologize. I am reopening the PR.

1 similar comment
@JakobL-MSFT
Copy link
Contributor

I closed this PR unintentionally. I apologize. I am reopening the PR.

@JakobL-MSFT JakobL-MSFT reopened this May 22, 2024
@JakobL-MSFT JakobL-MSFT requested a review from a team as a code owner May 22, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants