Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate WDK VSIX Install #1219

Merged
merged 12 commits into from
Sep 24, 2024
Merged

Deprecate WDK VSIX Install #1219

merged 12 commits into from
Sep 24, 2024
+71 −113

Conversation

middlemose
Copy link
Contributor

Deprecating the WDK VSIX install in favor of using new WDK Extension Visual Studio component.

Note: The Runner Image comes with the extension component pre-installed.

@middlemose middlemose requested a review from a team as a code owner September 19, 2024 15:16
JakobL-MSFT
JakobL-MSFT requested changes Sep 19, 2024
View reviewed changes
Build-SampleSet.ps1 Outdated Show resolved Hide resolved
Build-SampleSet.ps1 Show resolved Hide resolved
Build-SampleSet.ps1 Show resolved Hide resolved
Building-Locally.md Show resolved Hide resolved
configuration_vsonly.dsc.yaml Show resolved Hide resolved
Build-SampleSet.ps1 Show resolved Hide resolved
NeoAdonis
NeoAdonis approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@NeoAdonis NeoAdonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small comment, everything seems good to me. Thank you for making these changes!

.github/scripts/Install-Vsix.ps1 Outdated Show resolved Hide resolved
NeoAdonis
NeoAdonis reviewed Sep 19, 2024
View reviewed changes
Building-Locally.md Outdated Show resolved Hide resolved
JakobL-MSFT
JakobL-MSFT requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@JakobL-MSFT JakobL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See individual conversations.

JakobL-MSFT
JakobL-MSFT requested changes Sep 20, 2024
View reviewed changes
Building-Locally.md Outdated Show resolved Hide resolved
Building-Locally.md Outdated Show resolved Hide resolved
JakobL-MSFT
JakobL-MSFT requested changes Sep 23, 2024
View reviewed changes
.github/workflows/Code-Scanning.yml Show resolved Hide resolved
Building-Locally.md Show resolved Hide resolved
Building-Locally.md Show resolved Hide resolved
@middlemose middlemose merged commit 5c4ceae into microsoft:develop Sep 24, 2024
6 of 7 checks passed
@middlemose middlemose deleted the develop branch September 24, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-ronstadt jacob-ronstadt jacob-ronstadt approved these changes

@JakobL-MSFT JakobL-MSFT JakobL-MSFT approved these changes

@NeoAdonis NeoAdonis NeoAdonis approved these changes

@prashantchahar prashantchahar Awaiting requested review from prashantchahar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@middlemose @NeoAdonis @JakobL-MSFT @jacob-ronstadt