[WDI Sample] Refactoring Platform File IO ops to use WDM calls #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is into main branch. That branch is closed. Please stage PR to develop branch. |
equetzal
changed the title
equetzal
force-pushed
the
user/equetzal/refactor_WDI_Sample_Driver_To_Support_ARM64
branch
from
a7bb7e3 to
368b9fd
Compare
equetzal
force-pushed
the
user/equetzal/refactor_WDI_Sample_Driver_To_Support_ARM64
branch
from
cc72c4f to
7567118
Compare
equetzal
changed the base branch from
user/seromero/network-wlan-arm64
to
develop
|
For some reason the automated gates didn't trigger. Weird... I'll check if this is an issue with the actions themselves or something in the PR. I'll approve after checking manually that the sample builds successfully. Keep pursuing review from the Wi-Fi core team, please! |
NeoAdonis
approved these changes
Mar 21, 2024
|
@NeoAdonis . I also was surprised the gates did not work. I would be curious to learn why this is. |
youyanggit
approved these changes
Mar 21, 2024
|
Ok @JakobL-MSFT, @NeoAdonis , UU just approved from the Wifi Core team. We can merge now. |
equetzal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change being made?
The current implementation of the WDI driver example uses calls to deprecated NDIS functions:
NdisOpenFile,NdisMapFile,NdisUnmapFile,NdisCloseFile.NDIS have deprecated the use of this functions and stick to only network-related operations which left this file operations not available for ARM64 architecture. Due to the current efforts to support ARM64, we need to refactor pieces of code within this driver to avoid the use of the deprecated NDIS calls such that we have a buildable driver for both x86_64 and ARM64.
What changed?
Refactored
PlatformReadFile,PlatformOpenFile,PlatformMapFile,PlatformUnMapFile,PlatformCloseFileand `PlatformReadAndMapFile, to use the WDM calls for file operations and memory operations. This PR is the first step to enable the ARM64 support for this driver.