Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code-Scanning.yml jobs to use Node.js 20 #1134

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

jacob-ronstadt
Copy link
Contributor

actions/checkout to v4 and microsoft/setup-msbuild to v2

@jacob-ronstadt jacob-ronstadt requested a review from a team as a code owner March 4, 2024 18:07
@JakobL-MSFT
Copy link
Contributor

I may be creating more work here, but we should make sure CodeQL workflow is aligned as close as reasonably possible with https://github.com/microsoft/Windows-driver-samples/blob/main/.github/workflows/ci.yml and https://github.com/microsoft/Windows-driver-samples/blob/main/.github/workflows/ci-pr.yml . Those two workflows uses actions that you are updating, so we should also update them for those two files. Jacob you could take a stab at this and coordinate with @NeoAdonis .

In hindsight I see similar issue here: https://github.com/microsoft/Windows-driver-samples/actions/runs/8133471231 and here: https://github.com/microsoft/Windows-driver-samples/actions/runs/8133038769 .

@NeoAdonis
Copy link
Member

I agree with this observation Jakob made. Thanks for the heads-up!

@jacob-ronstadt : Because you have a PR already, could you implement the same change in both ci.yml and ci-pr.yml, please? I could create a separate PR if you prefer that instead.

@jacob-ronstadt
Copy link
Contributor Author

@NeoAdonis @JakobL-MSFT Updated!

@JakobL-MSFT JakobL-MSFT self-requested a review March 6, 2024 01:17
@NeoAdonis NeoAdonis merged commit bcc5c13 into microsoft:develop Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants