-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove x86 and ARM configurations for sample projects. #1126
Conversation
Stats building using the latest EWDK preview: Before this change:
* on Debug|Win32 only After this change:
As expected, all driver samples failed because of conditions disallowing the usage of x86 and ARM to build drivers. All applications for drivers succeeded, however. The 4 failed samples after the configurations removal are the general/dchu collection that needs to be updated separately because the solution actually uses properties from the x86 and ARM configurations as a basis to build for x64 and ARM64, thus it cannot be updated using a script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GNSS & RadioManager changes look ok to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bluetooth lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ETW seems fine
This pull request involves changes to the project configurations and solutions to remove Win32 and Arm support:
Win32
andArm
from the project configurations. This includes removing the associatedPropertyGroup
,ImportGroup
, andItemDefinitionGroup
entries for these platforms.The following samples that were able to build successfully under the latest WDK on x86 will have their support removed. If for some reason you need these deprecated versions of the samples, please take a look at the archived releases: