Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x86 and ARM configurations for sample projects. #1126

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Conversation

NeoAdonis
Copy link
Contributor

@NeoAdonis NeoAdonis commented Feb 22, 2024

This pull request involves changes to the project configurations and solutions to remove Win32 and Arm support:

  • Removed Win32 and Arm from the project configurations. This includes removing the associated PropertyGroup, ImportGroup, and ItemDefinitionGroup entries for these platforms.
  • Set default platform to x64.

The following samples that were able to build successfully under the latest WDK on x86 will have their support removed. If for some reason you need these deprecated versions of the samples, please take a look at the archived releases:

  • avstream/sampledevicemft
  • general/toaster/toastpkg
  • general/tracing/systemtracecontrol
  • hid/hclient
  • input/layout
  • network/config/bindview
  • network/radio/radiomanagersample
  • network/trans/inspect
  • nfp/net
  • setup/devcon
  • storage/iscsi
  • storage/tools/spti
  • usb/usbview
  • video/archive/pixlib
  • wia
  • wmi/wmiacpi

Verified

This commit was signed with the committer’s verified signature.
Exirel Florian Strzelecki
@NeoAdonis
Copy link
Contributor Author

Stats building using the latest EWDK preview:

Before this change:

Architecture Unsupported Failed Succeeded
x86/Win32 9 104 (-1*) 15 (+1*)
ARM 116 11 3

* on Debug|Win32 only

After this change:

Architecture Unsupported Failed Succeeded
x86/Win32 126 4 0
ARM 126 4 0

As expected, all driver samples failed because of conditions disallowing the usage of x86 and ARM to build drivers. All applications for drivers succeeded, however.

The 4 failed samples after the configurations removal are the general/dchu collection that needs to be updated separately because the solution actually uses properties from the x86 and ARM configurations as a basis to build for x64 and ARM64, thus it cannot be updated using a script.

@NeoAdonis NeoAdonis marked this pull request as ready for review February 23, 2024 23:03
@NeoAdonis NeoAdonis requested review from a team as code owners February 23, 2024 23:03
@NeoAdonis NeoAdonis removed the request for review from a team February 23, 2024 23:03
@NeoAdonis NeoAdonis requested a review from a team February 23, 2024 23:04
Copy link

@aschoorl aschoorl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GNSS & RadioManager changes look ok to me.

Copy link
Contributor

@rahul-ramadas rahul-ramadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bluetooth lgtm.

Copy link

@Robo210 Robo210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ETW seems fine

@NeoAdonis NeoAdonis merged commit 3fcc0f2 into develop Feb 26, 2024
8 checks passed
@NeoAdonis NeoAdonis deleted the remove-x86 branch February 26, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants