Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TrEE Sample #1124

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fix TrEE Sample #1124

merged 2 commits into from
Feb 21, 2024

Conversation

JakobL-MSFT
Copy link
Contributor

@JakobL-MSFT JakobL-MSFT commented Feb 21, 2024

The TrEE sample is literally the last sample on our .\exclusion.csv list. Let's get it to build!!

This fix does narrow fixes to achieve exactly that and at same time adds arm64 as a target OS.

More specifically:

  • This PR removes TrEE from the .\exclusion.csv list.
  • This PR adds arm64 target support to vcxproj and sln file.
  • This PR avoid including non-existing header file and instead adds typedef directly (see beneath).
  • This PR includes project header files with "..\inc\foo.h" rather than <foo.h>. I am not quite sure what the best way to write this is. But at least this works :-) .
  • This PR fixes a requirement to not use ExAllocatePoolWithTag

How tested:

  • Built for all four flavors in:
  • WDK 22621
  • EWDK.ni_release_svc_prod1.22621.2428
  • EWDK.ge_release.26063.1

Note: There is no suitable header file currently available that defines CHAR16:

C:\Program Files (x86)\Windows Kits\10\Include>findstr /s /m CHAR16 *
10.0.22621.0\km\treevariableservice.h
10.0.22621.0\um\icu.h
10.0.22621.0\um\icucommon.h
10.0.22621.0\um\mi.h
10.0.22621.0\um\WbemCli.h
10.0.22621.0\um\WbemCli.Idl

@JakobL-MSFT JakobL-MSFT marked this pull request as ready for review February 21, 2024 04:00
@JakobL-MSFT JakobL-MSFT requested review from a team as code owners February 21, 2024 04:00
@JakobL-MSFT
Copy link
Contributor Author

I am going to complete this PR as I would like it my build for tonight and clearly we are better off with this change than without. More feedback is welcome after completion.

@JakobL-MSFT JakobL-MSFT merged commit cfeff01 into develop Feb 21, 2024
7 of 8 checks passed
@JakobL-MSFT JakobL-MSFT deleted the user/jakobl/fix_TrEE branch February 21, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant