Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated exallocatepool* APIs with their modern replacement #1088

Merged

Conversation

Spruill-1
Copy link
Contributor

Re-doing this PR against the develop branch.

@Spruill-1
Copy link
Contributor Author

@JakobL-MSFT Correct target branch this round?

@JakobL-MSFT
Copy link
Contributor

Yes, right branch :-) Thank you so much. I have an unrelated comment I will post separately.

@JakobL-MSFT JakobL-MSFT self-requested a review January 25, 2024 17:39
Copy link
Contributor

@JakobL-MSFT JakobL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David. Let us please handle internal bug 48004707 prior to completing PR 1088. I sent email.

JakobL-MSFT added a commit that referenced this pull request Feb 1, 2024
@JakobL-MSFT JakobL-MSFT merged commit 07936d8 into microsoft:develop Feb 6, 2024
14 checks passed
JakobL-MSFT added a commit that referenced this pull request Feb 7, 2024
* user/jakobl/simplify_flags

* user/jakobl/simplify_flags

* Update Build-Sample.ps1

* Merge with upcoming PR #1088

* white space only change
@osy
Copy link

osy commented Dec 20, 2024

@JakobL-MSFT This change is broken. You cannot replace ExAllocatePoolWithTag with ExAllocatePool2 directly because the argument type changed from POOL_TYPE to POOL_FLAGS. The driver will refuse to load with Code 31 (STATUS_NO_MEMORY). May I ask how this change was tested by Microsoft before being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants