-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for sample build errors and updates to the execution script to use new build flags #1078
Conversation
The change looks great. I have submitted two additional commits, First a small comment change, and secondly an updated exclusion.csv file. With this the repo builds cleanly for the develop branch using GE WDK. However for NI WDK this PR makes 34 drivers fail to build. I have sent details offline. |
…hat we need to understand better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks excellent for GE. However it reveals a lot of issues for NI that we should understand better (and perhaps address) prior to merging.
I merged with recent changes to the develop branch. I also updated as follows:
This works great with GE EWDK. However, for NI WDK this PR makes 33 drivers fail to build. I have sent details offline. |
No description provided.