Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for sample build errors and updates to the execution script to use new build flags #1078

Merged
merged 16 commits into from
Jan 31, 2024

Conversation

zlockard
Copy link
Collaborator

No description provided.

@zlockard zlockard requested review from a team as code owners January 19, 2024 05:49
@JakobL-MSFT
Copy link
Contributor

The change looks great. I have submitted two additional commits, First a small comment change, and secondly an updated exclusion.csv file. With this the repo builds cleanly for the develop branch using GE WDK. However for NI WDK this PR makes 34 drivers fail to build. I have sent details offline.

Copy link
Contributor

@JakobL-MSFT JakobL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks excellent for GE. However it reveals a lot of issues for NI that we should understand better (and perhaps address) prior to merging.

@JakobL-MSFT
Copy link
Contributor

I merged with recent changes to the develop branch. I also updated as follows:

  • The exclusion.csv file is minimal. No exclusions for inf issues.
  • Build-Sample.ps1 is updated to correctly reflect remaining inf issues. Detailed comments shows the few remaining issues.

This works great with GE EWDK.

However, for NI WDK this PR makes 33 drivers fail to build. I have sent details offline.

@zlockard zlockard requested a review from a team as a code owner January 31, 2024 01:30
@zlockard zlockard merged commit 24f280d into develop Jan 31, 2024
8 checks passed
@JakobL-MSFT JakobL-MSFT deleted the user/zlockard/sample_updates branch February 15, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants