Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .exe from the INF file #1040

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Remove .exe from the INF file #1040

merged 1 commit into from
Oct 9, 2023

Conversation

zlockard
Copy link
Collaborator

@zlockard zlockard commented Oct 6, 2023

No description provided.

@zlockard zlockard requested a review from a team as a code owner October 6, 2023 20:20
@cgallred
Copy link
Contributor

cgallred commented Oct 6, 2023

@jasonknichel how can I look at the changes? GitHub thinks these .inf files are binary, I think because they are UTF16, so it won't show me the diffs.

@jasonknichel
Copy link
Collaborator

jasonknichel commented Oct 6, 2023

@jasonknichel how can I look at the changes? GitHub thinks these .inf files are binary, I think because they are UTF16, so it won't show me the diffs.

@cgallred - yea, git and github don't like UTF-16 files and considers them binary. :( It only does a proper text diff for ASCII and UTF-8. I diff INF files (which PNP requires to be ASCII or UTF-16 LE, with UTF-16 LE preferred since it allows proper localization) by doing the diff locally in my local clone of the sample repo. For this change, I saw that the commit ID was b0dad9afddee741cbb5422fa8bacdc6a545f4576 so in my local clone, I did this to view the changes:

git difftool -d b0dad9afddee741cbb5422fa8bacdc6a545f4576~1 b0dad9afddee741cbb5422fa8bacdc6a545f4576

@zlockard
Copy link
Collaborator Author

zlockard commented Oct 9, 2023

For some context here - VS/WDK doesn't have support for integrating binaries from two projects into an INF file and building the INF inline. The last PR and this one separated the exe from the INF so that the driver itself would build cleanly

@zlockard zlockard merged commit 650bc18 into develop Oct 9, 2023
@zlockard zlockard deleted the avscan_fix branch October 30, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants