Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnsafeCallInGlobalinit: CodeQL port of C28637 #166

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

jacob-ronstadt
Copy link
Contributor

Checklist for Pull Requests

  • Description is filled out.
  • Only one query or related query group is in this pull request.
  • The version number on changed queries has been increased via the @version comment in the file header.
  • All unit tests have been run: (Test README.md).
  • Commands codeql database create and codeql database analyze have completed successfully.
  • A .qhelp file has been added for any new queries or updated if changes have been made to an existing query.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • src/drivers/general/queries/experimental/UnsafeCallInGlobalInit/UnsafeCallInGlobalInit.qhelp: Language not supported
  • src/drivers/general/queries/experimental/UnsafeCallInGlobalInit/UnsafeCallInGlobalInit.ql: Language not supported
  • src/drivers/general/queries/experimental/UnsafeCallInGlobalInit/UnsafeCallInGlobalInit.sarif: Language not supported
  • src/drivers/general/queries/experimental/UnsafeCallInGlobalInit/driver_snippet.c: Language not supported
Comments suppressed due to low confidence (1)

src/drivers/test/build_create_analyze_test.py:248

  • The comment should start with a capital 'E': 'Exclude empty template driver_snippet files'.
#exclude empty template driver_snippet files
@jacob-ronstadt jacob-ronstadt changed the title CodeQL port of C28637 UnsafeCallInGlobalinit: CodeQL port of C28637 Feb 7, 2025
@jacob-ronstadt jacob-ronstadt merged commit aeb1987 into development Feb 10, 2025
4 of 5 checks passed
@jacob-ronstadt jacob-ronstadt deleted the jacob-ronstadt/c28637 branch February 10, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants