Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes to Color pages #1670

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

Jay-o-Way
Copy link
Contributor

Description

Changed one "control" to "card", make every Description end with a period.

Motivation and Context

just tweaking

How Has This Been Tested?

With Visual Studio :)

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Jay-o-Way
Copy link
Contributor Author

Question:
Schermafbeelding 2024-11-28 174351

@Zakariathr22
Copy link
Contributor

Question: Schermafbeelding 2024-11-28 174351

I believe this is another issue that occurs when the theme is toggled and should be reported, because the background of the "Smoke Background" color example does not update when the theme is toggled.
Before toggling the theme
image
After toggling the theme
image

Co-authored-by: Niels Laute <[email protected]>
@niels9001 niels9001 self-requested a review December 2, 2024 16:27
Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@marcelwgn
Copy link
Contributor

/azp run

1 similar comment
@niels9001
Copy link
Contributor

/azp run

@niels9001 niels9001 merged commit 96beae3 into microsoft:main Dec 6, 2024
2 checks passed
@Jay-o-Way Jay-o-Way deleted the Color-Pages-tweaks branch December 6, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants