Clean up App.xaml.cs #1628
Open
Clean up App.xaml.cs #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkarl
reviewed
Nov 13, 2024
|
/azp run |
niels9001
reviewed
Dec 6, 2024
| /// executed, and as such is the logical equivalent of main() or WinMain(). | ||
| /// </summary> | ||
| public App() | ||
| { | ||
| this.InitializeComponent(); | ||
|
|
||
| #if WINUI_PRERELEASE |
There was a problem hiding this comment.
Not sure if this is related to using WinUI Gallery with (internal) builds of WASDK?
There was a problem hiding this comment.
The code I removed was UWP code that doesn't work on the WASDK.
niels9001
reviewed
Dec 6, 2024
|
|
||
| public void EnableSound(bool withSpatial = false) | ||
| { | ||
| ElementSoundPlayer.State = ElementSoundPlayerState.On; |
There was a problem hiding this comment.
This still works today in WinUI, right? There's a setting in Settings to turn this on/off
There was a problem hiding this comment.
The function is not being used and the setting works without it.
niels9001
reviewed
Dec 6, 2024
WinUIGallery/App.xaml.cs
Outdated
| public Frame GetRootFrame() | ||
| { | ||
| Frame rootFrame; | ||
| NavigationRootPage rootPage = StartupWindow.Content as NavigationRootPage; | ||
| var rootPage = StartupWindow.Content as NavigationRootPage; | ||
| if (rootPage == null) |
There was a problem hiding this comment.
While we fix this, could we do this instead:
if (StaturWindow.Content is NavigationRootPage rootpage)
MGGSK
force-pushed
the
Cleanup-app.xaml.cs
branch
from
f2ad3b1 to
96beae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the app.xaml.cs file.
Description
1.Removed UWP code from the file.
2.Added comments to the file.
3.Made the code cleaner.
4.Removed unused code.
Motivation and Context
UWP code should not be in a WinUI app.
How Has This Been Tested?
No testing needed.
Types of changes