Adding SearchBox to Gallery #662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshit7962
added
* NO MERGE *
dipeshmsft
reviewed
Oct 4, 2024
| @@ -51,6 +71,20 @@ public void Forward() | |||
| public MainWindowViewModel(INavigationService navigationService) | |||
| { | |||
| _controls = ControlsInfoDataSource.Instance.ControlsInfo; | |||
|
|
|||
| _allPages = new ObservableCollection<ControlInfoDataItem>(); | |||
There was a problem hiding this comment.
You can just access the GetAllPages() function from ControlsInfoDataSource for this.
| @@ -111,6 +115,39 @@ public ICollection<ControlInfoDataItem> GetAllControlsInfo() | |||
| return allControls; | |||
| } | |||
|
|
|||
| private void GetAllPages() | |||
There was a problem hiding this comment.
Suggested change
| private void GetAllPages() | |
| public ICollection<ControlInfoDataItem> GetAllPages() |
| @@ -70,6 +72,8 @@ private ControlsInfoDataSource() | |||
| { | |||
| var jsonText = ReadControlsData(); | |||
| ControlsInfo = JsonSerializer.Deserialize<List<ControlInfoDataItem>>(jsonText); | |||
|
|
|||
| GetAllPages(); | |||
There was a problem hiding this comment.
Suggested change
| GetAllPages(); | |
| _allPages = GetAllPages(); |
| } | ||
| } | ||
|
|
||
| public ObservableCollection<ControlInfoDataItem> FilterItems(string filterText) |
There was a problem hiding this comment.
Why not return ICollection<ControlInfoDataItem> from here ?
|
Closing as long standing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #633
The following implementation adds search box functionality to search/filter out controls in gallery application
Microsoft Reviewers: Open in CodeFlow