This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
feat: Japanese language support #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #922 +/- ##
=========================================
- Coverage 87.9% 87.8% -0.1%
=========================================
Files 129 131 +2
Lines 4845 4963 +118
Branches 922 984 +62
=========================================
+ Hits 4259 4358 +99
- Misses 584 603 +19
Partials 2 2
Continue to review full report at Codecov.
|
wbreza
approved these changes
Nov 12, 2019
peaceiris
reviewed
Nov 19, 2019
|
Whitespace like the following should be removed. - ローカル プロジェクトを開く
+ ローカルプロジェクトを開く |
peaceiris
reviewed
Nov 19, 2019
peaceiris
reviewed
Nov 19, 2019
peaceiris
reviewed
Nov 19, 2019
peaceiris
reviewed
Nov 19, 2019
peaceiris
reviewed
Nov 19, 2019
peaceiris
reviewed
Nov 19, 2019
peaceiris
reviewed
Nov 19, 2019
peaceiris
reviewed
Nov 19, 2019
peaceiris
reviewed
Nov 19, 2019
|
Thanks a lot @peaceiris ! Really appreciate the feedback, got it verified by @aykhara and everything looks great and is added in bf0d273 |
peaceiris
reviewed
Dec 13, 2019
peaceiris
reviewed
Dec 13, 2019
| @@ -112,7 +112,7 @@ export const japanese: IAppStrings = { | |||
| visitedAssets: "訪問済みアセット（${count}）", // Visited Assets (${count}), | |||
| taggedAssets: "タグ付きアセット（${count}）", // Tagged Assets (${count}), | |||
| nonTaggedAssets: "タグ付けされていないアセット（${count}）", // Not Tagged Assets (${count}), | |||
| nonVisitedAssets: " 未訪問ないアセット（${count}）", // Not Visited Assets (${count}), | |||
| nonVisitedAssets: "未訪問ないアセット（${count}）", // Not Visited Assets (${count}), | |||
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Japanese translation verified by @aykhara and other native Japanese speakers