Destructuring assignment removes undefined from type when default value is given #9422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhegazy I think you are the best person to look at this while @ahejlsberg is gone. |
|
Looks good to me. i would give @ahejlsberg some more time to check it as well. |
|
Sure. @ahejlsberg do you want to take a look? |
| // In strict null checking mode, if a default value of a non-undefined type is specified, remove | ||
| // undefined from the final type. | ||
| if (strictNullChecks && | ||
| !(getCombinedTypeFlags(checkExpressionCached(prop.objectAssignmentInitializer)) & TypeFlags.Undefined)) { |
There was a problem hiding this comment.
Use checkExpression here, not checkExpressionCached. The latter should only be used (a) when you know that contextual types will never have an effect on the expression and (b) when other checks of the same expression also use the caching version. Neither are true here.
|
👍 Once you make the indicated change. |
mhegazy
deleted the
allow-destructuring-assignment-with-default-of-undefined-optional-property
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9341