Don't issue implicit any when obtaining the implied type for a binding pattern #60083

ahejlsberg · 2024-09-27T14:03:11Z

Fixes #59936. See my comment here.

@Andarist Borrowed tests from #59975. Thanks!

jakebailey · 2024-09-27T15:22:26Z

typescript-bot · 2024-09-27T15:22:30Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-27T15:44:43Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-27T15:48:56Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60083/merge:

Everything looks good!

typescript-bot · 2024-09-27T16:03:21Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,794k (± 0.72%)}	_{195,799k (± 0.72%)}	_~	_192,949k	_196,525k	_{p=0.936 n=6}
_{Parse Time}	_{1.62s (± 0.82%)}	_{1.59s (± 1.23%)}	_{-0.02s (- 1.54%)}	_1.56s	_1.61s	_{p=0.021 n=6}
_{Bind Time}	_{0.88s (± 0.93%)}	_{0.86s (± 0.60%)}	_{-0.01s (- 1.52%)}	_0.86s	_0.87s	_{p=0.014 n=6}
_{Check Time}	_{11.73s (± 0.78%)}	_{11.74s (± 0.41%)}	_~	_11.65s	_11.78s	_{p=0.688 n=6}
_{Emit Time}	_{3.36s (± 4.46%)}	_{3.34s (± 2.94%)}	_~	_3.28s	_3.54s	_{p=0.936 n=6}
_{Total Time}	_{17.58s (± 0.68%)}	_{17.54s (± 0.35%)}	_~	_17.49s	_17.65s	_{p=0.936 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,102	_947,102	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,738	_410,738	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,074k (± 0.00%)}	_{1,224,085k (± 0.00%)}	_~	_1,224,038k	_1,224,164k	_{p=0.810 n=6}
_{Parse Time}	_{6.62s (± 0.85%)}	_{6.64s (± 0.55%)}	_~	_6.59s	_6.68s	_{p=0.416 n=6}
_{Bind Time}	_{1.88s (± 0.22%)}	_{1.88s (± 0.52%)}	_~	_1.86s	_1.89s	_{p=0.753 n=6}
_{Check Time}	_{31.68s (± 0.36%)}	_{31.67s (± 0.29%)}	_~	_31.52s	_31.81s	_{p=0.748 n=6}
_{Emit Time}	_{15.12s (± 0.24%)}	_{15.13s (± 0.57%)}	_~	_15.02s	_15.28s	_{p=1.000 n=6}
_{Total Time}	_{55.30s (± 0.24%)}	_{55.32s (± 0.20%)}	_~	_55.20s	_55.51s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,521,651	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,037	_936,037	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,351,733k (± 0.00%)}	_{2,351,763k (± 0.00%)}	_~	_2,351,682k	_2,351,940k	_{p=1.000 n=6}
_{Parse Time}	_{9.40s (± 0.28%)}	_{9.40s (± 0.31%)}	_~	_9.35s	_9.43s	_{p=0.868 n=6}
_{Bind Time}	_{2.19s (± 0.37%)}	_{2.18s (± 0.63%)}	_~	_2.17s	_2.20s	_{p=0.557 n=6}
_{Check Time}	_{75.83s (± 0.24%)}	_{76.40s (± 1.41%)}	_~	_75.60s	_78.51s	_{p=0.470 n=6}
_{Emit Time}	_{0.28s (± 2.70%)}	_{0.28s (± 2.95%)}	_~	_0.27s	_0.29s	_{p=0.729 n=6}
_{Total Time}	_{87.69s (± 0.20%)}	_{88.25s (± 1.21%)}	_~	_87.48s	_90.33s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,668	_1,250,671	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,081	_265,082	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,405,846k (± 0.01%)}	_{2,406,113k (± 0.01%)}	_~	_2,405,674k	_2,406,613k	_{p=0.230 n=6}
_{Parse Time}	_{5.15s (± 0.61%)}	_{5.13s (± 0.86%)}	_~	_5.08s	_5.20s	_{p=0.229 n=6}
_{Bind Time}	_{1.94s (± 0.46%)}	_{1.94s (± 0.90%)}	_~	_1.91s	_1.96s	_{p=0.804 n=6}
_{Check Time}	_{35.38s (± 0.26%)}	_{35.41s (± 0.27%)}	_~	_35.26s	_35.50s	_{p=0.471 n=6}
_{Emit Time}	_{3.09s (± 4.05%)}	_{2.99s (± 0.65%)}	_{🟩-0.10s (- 3.34%)}	_2.96s	_3.01s	_{p=0.020 n=6}
_{Total Time}	_{45.56s (± 0.42%)}	_{45.46s (± 0.16%)}	_~	_45.33s	_45.55s	_{p=0.335 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,668	_1,250,671	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,081	_265,082	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,480,429k (± 0.01%)}	_{2,480,422k (± 0.01%)}	_~	_2,480,134k	_2,481,028k	_{p=0.936 n=6}
_{Parse Time}	_{5.32s (± 0.75%)}	_{5.33s (± 1.07%)}	_~	_5.26s	_5.40s	_{p=0.689 n=6}
_{Bind Time}	_{1.73s (± 0.67%)}	_{1.72s (± 0.44%)}	_~	_1.71s	_1.73s	_{p=0.150 n=6}
_{Check Time}	_{35.77s (± 0.28%)}	_{35.83s (± 0.22%)}	_~	_35.70s	_35.93s	_{p=0.261 n=6}
_{Emit Time}	_{3.02s (± 1.25%)}	_{3.03s (± 1.43%)}	_~	_2.97s	_3.08s	_{p=0.570 n=6}
_{Total Time}	_{45.84s (± 0.22%)}	_{45.93s (± 0.25%)}	_~	_45.79s	_46.10s	_{p=0.199 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,987	_260,990	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,423	_106,424	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{436,890k (± 0.01%)}	_{436,898k (± 0.01%)}	_~	_436,828k	_436,958k	_{p=0.378 n=6}
_{Parse Time}	_{3.48s (± 1.01%)}	_{3.50s (± 1.15%)}	_~	_3.43s	_3.54s	_{p=0.295 n=6}
_{Bind Time}	_{1.29s (± 1.27%)}	_{1.29s (± 1.96%)}	_~	_1.26s	_1.32s	_{p=0.625 n=6}
_{Check Time}	_{18.80s (± 0.35%)}	_{18.83s (± 0.34%)}	_~	_18.76s	_18.92s	_{p=0.810 n=6}
_{Emit Time}	_{1.47s (± 1.19%)}	_{1.48s (± 1.58%)}	_~	_1.45s	_1.51s	_{p=0.807 n=6}
_{Total Time}	_{25.04s (± 0.24%)}	_{25.09s (± 0.43%)}	_~	_24.90s	_25.21s	_{p=0.296 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,006k (± 0.02%)}	_{370,955k (± 0.01%)}	_~	_370,879k	_371,012k	_{p=0.471 n=6}
_{Parse Time}	_{2.92s (± 1.43%)}	_{2.91s (± 1.18%)}	_~	_2.85s	_2.95s	_{p=0.872 n=6}
_{Bind Time}	_{1.60s (± 1.25%)}	_{1.62s (± 1.06%)}	_~	_1.59s	_1.64s	_{p=0.059 n=6}
_{Check Time}	_{16.35s (± 0.30%)}	_{16.34s (± 0.42%)}	_~	_16.24s	_16.45s	_{p=0.935 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.87s (± 0.15%)}	_{20.88s (± 0.31%)}	_~	_20.80s	_20.99s	_{p=0.872 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,105,040	_3,105,040	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,070,163	_1,070,163	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,199,128k (± 0.01%)}	_{3,199,173k (± 0.01%)}	_~	_3,198,388k	_3,199,423k	_{p=0.689 n=6}
_{Parse Time}	_{14.04s (± 0.91%)}	_{14.05s (± 0.60%)}	_~	_13.91s	_14.16s	_{p=0.573 n=6}
_{Bind Time}	_{4.41s (± 0.25%)}	_{4.41s (± 0.45%)}	_~	_4.38s	_4.43s	_{p=0.865 n=6}
_{Check Time}	_{85.77s (± 3.01%)}	_{85.38s (± 1.05%)}	_~	_84.53s	_87.06s	_{p=0.423 n=6}
_{Emit Time}	_{24.07s (± 9.14%)}	_{23.28s (± 7.59%)}	_~	_22.31s	_26.79s	_{p=0.378 n=6}
_{Total Time}	_{128.29s (± 2.27%)}	_{127.12s (± 2.01%)}	_~	_125.69s	_132.29s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_279,071	_279,071	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,893	_113,893	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,715k (± 0.05%)}	_{428,776k (± 0.02%)}	_~	_428,700k	_428,866k	_{p=0.575 n=6}
_{Parse Time}	_{4.06s (± 0.67%)}	_{4.06s (± 1.08%)}	_~	_4.01s	_4.14s	_{p=0.467 n=6}
_{Bind Time}	_{1.74s (± 1.49%)}	_{1.73s (± 1.77%)}	_~	_1.67s	_1.75s	_{p=0.934 n=6}
_{Check Time}	_{18.32s (± 2.00%)}	_{18.14s (± 0.57%)}	_~	_18.02s	_18.30s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.12s (± 1.53%)}	_{23.93s (± 0.51%)}	_~	_23.77s	_24.08s	_{p=0.229 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,027	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,292	_181,292	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,598k (± 0.01%)}	_{483,606k (± 0.01%)}	_~	_483,576k	_483,662k	_{p=0.748 n=6}
_{Parse Time}	_{3.35s (± 0.62%)}	_{3.36s (± 1.23%)}	_~	_3.28s	_3.40s	_{p=0.466 n=6}
_{Bind Time}	_{1.18s (± 0.88%)}	_{1.17s (± 0.71%)}	_~	_1.16s	_1.18s	_{p=0.788 n=6}
_{Check Time}	_{18.91s (± 0.25%)}	_{18.90s (± 0.41%)}	_~	_18.78s	_19.00s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{23.45s (± 0.24%)}	_{23.44s (± 0.27%)}	_~	_23.36s	_23.55s	_{p=0.575 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-27T17:02:04Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60083/merge:

Everything looks good!

src/compiler/checker.ts

jakebailey · 2024-09-27T18:55:59Z

@typescript-bot cherry-pick this to release-5.6

typescript-bot · 2024-09-27T18:56:03Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.6`	✅ Started	✅ Results

typescript-bot · 2024-09-27T18:58:34Z

Hey, @jakebailey! I've created #60086 for you.

…e-5.6 (#60086) Co-authored-by: Anders Hejlsberg <[email protected]>

ahejlsberg added 3 commits September 27, 2024 06:47

No widening errors when obtaining implied binding pattern type

7c893fe

Add tests

8ee94a9

Accept new baselines

39364ee

typescript-bot assigned ahejlsberg Sep 27, 2024

typescript-bot added Author: Team For Backlog Bug PRs that fix a backlog bug labels Sep 27, 2024

ahejlsberg requested a review from jakebailey September 27, 2024 14:03

burtek mentioned this pull request Sep 27, 2024

chore(deps): update dependency typescript to ~5.6.0 (master) burtek/eslint-config#154

Merged

1 task

jakebailey reviewed Sep 27, 2024

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

Fix formatting

1c25b1a

jakebailey changed the title ~~Fix59936~~ Don't issue implicit any when obtaining the implied type for a binding pattern Sep 27, 2024

typescript-bot mentioned this pull request Sep 27, 2024

🤖 Pick PR #60083 (Don't issue implicit any when obtai...) into release-5.6 #60086

Merged

jakebailey approved these changes Oct 1, 2024

View reviewed changes

jakebailey merged commit ca18009 into main Oct 1, 2024
32 checks passed

jakebailey deleted the fix59936 branch October 1, 2024 04:38

DanielRosenwasser pushed a commit that referenced this pull request Oct 8, 2024

🤖 Pick PR #60083 (Don't issue implicit any when obtai...) into releas…

fefa70a

…e-5.6 (#60086) Co-authored-by: Anders Hejlsberg <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't issue implicit any when obtaining the implied type for a binding pattern #60083

Don't issue implicit any when obtaining the implied type for a binding pattern #60083

ahejlsberg commented Sep 27, 2024 •

edited

Loading

jakebailey commented Sep 27, 2024

typescript-bot commented Sep 27, 2024 •

edited

Loading

typescript-bot commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

tsc

typescript-bot commented Sep 27, 2024

jakebailey commented Sep 27, 2024

typescript-bot commented Sep 27, 2024 •

edited

Loading

typescript-bot commented Sep 27, 2024

Don't issue implicit any when obtaining the implied type for a binding pattern #60083

Don't issue implicit any when obtaining the implied type for a binding pattern #60083

Conversation

ahejlsberg commented Sep 27, 2024 • edited Loading

jakebailey commented Sep 27, 2024

typescript-bot commented Sep 27, 2024 • edited Loading

typescript-bot commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

typescript-bot commented Sep 27, 2024

tsc

typescript-bot commented Sep 27, 2024

jakebailey commented Sep 27, 2024

typescript-bot commented Sep 27, 2024 • edited Loading

typescript-bot commented Sep 27, 2024

ahejlsberg commented Sep 27, 2024 •

edited

Loading

typescript-bot commented Sep 27, 2024 •

edited

Loading

typescript-bot commented Sep 27, 2024 •

edited

Loading