-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--moduleFormatInterop
(all names bikesheddable)
#58480
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…require(esm) error
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54102
Adds a flag
--moduleFormatInterop
to describe how imports of CommonJS modules and requires of ES modules work in the target runtime/bundler. The values are:node16
/nodenext
: the current behavior in--module node16
/nodenext
. That is, a default import of a CommonJS module always binds tomodule.exports
.bundler
: the current behavior in all other module modes. Default imports of CommonJS modules bind to eithermodule.exports
ormodule.exports.default
, depending on heuristics related to the presence/absence of__esModule
.bundlernode
: a behavior not achievable without this PR, which is required for good compatibility with Webpack and esbuild. For compatibility reasons, those bundlers use Node.js’s logic for importing CommonJS modules when the importing file would be interpreted as ESM by Node.js due to file extension or package.json"type"
. I explained this in more detail in a demo repository. This mode toggles the typing of imports based on module format detection, but continues to allowrequire(esm)
. (Note this is not a perfect fit for Webpack, which also prohibitsrequire(esm)
under the same Node.js compatibility conditions.)An alternate approach splitting import typing and
require(esm)
behavior is up at #58526.