Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set node-version for setup-node #58102

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

jakebailey
Copy link
Member

Not setting a node version here means you get the global install, and the global install does not always behave, e.g. actions/runner-images#9644 (comment)

Ensure these are all set to something. This should fix nightly and other tasks.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 7, 2024
@jakebailey
Copy link
Member Author

Bypassing merge requirements so that we don't continue to not have nightly builds.

@jakebailey jakebailey merged commit 10b5059 into microsoft:main Apr 7, 2024
25 checks passed
@jakebailey jakebailey deleted the set-node-version branch April 7, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants