Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect binary files by checking first 256 code units for 0xFFFD #57008

Merged
merged 7 commits into from
Jan 17, 2024
+31 −8
Merged

Detect binary files by checking first 256 code units for 0xFFFD #57008

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d3dd8b
Add test
jakebailey Jan 10, 2024
3fa526c
Try and ignore MPEG Transport Stream files
jakebailey Jan 10, 2024
4e80546
Remove redundant check
jakebailey Jan 10, 2024
a01ac5f
Just bail on NUL or replacementCharacter
jakebailey Jan 12, 2024
2f597d5
Use equality
jakebailey Jan 12, 2024
4ee2758
Just check for FFFD
jakebailey Jan 13, 2024
eb2dcc7
Just simply check via includes
jakebailey Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test
@jakebailey
jakebailey committed Jan 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 3d3dd8bdaf54f0d73470a37ebf6d829cd96eb806
1,696 changes: 1,696 additions & 0 deletions tests/baselines/reference/TransportStream.errors.txt
View file

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions tests/baselines/reference/TransportStream.js
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
//// [tests/cases/compiler/TransportStream.ts] ////

//// [TransportStream.ts]
G@�G@�G@�

//// [TransportStream.js]
G;
G;
G;
5 changes: 5 additions & 0 deletions tests/baselines/reference/TransportStream.symbols
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
//// [tests/cases/compiler/TransportStream.ts] ////

=== TransportStream.ts ===

G@�G@�G@�
11 changes: 11 additions & 0 deletions tests/baselines/reference/TransportStream.types
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
//// [tests/cases/compiler/TransportStream.ts] ////

=== TransportStream.ts ===
G@�G@�G@�
>G : any
> : any
>G : any
> : any
>G : any
> : any

1 change: 1 addition & 0 deletions tests/cases/compiler/TransportStream.ts
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
䝀ҒЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄЄ䝀֒ԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅԅ䝀ڒ؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆؆