Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue better error when unresolvable package in --moduleResolution node10 resolves with --moduleResolution bundler #56949

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Issue better error when unresolvable package in --moduleResolution node10 resolves with --moduleResolution bundler #56949

merged 8 commits into from
Jan 16, 2024

Conversation

andrewbranch
Copy link
Member

Fixes #55104

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 4, 2024
@andrewbranch
Copy link
Member Author

@sheetalkamat I'm not sure whether this is safe with the existing repopulateInfo infrastructure. Could you take a look?

@andrewbranch
Copy link
Member Author

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2024 •
edited
Loading

Heya @andrewbranch, I've started to run the regular perf test suite on this PR at 7383586. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 154.13ms (± 0.95%) 153.66ms (± 0.21%) -0.47ms (- 0.31%) 152.50ms 157.26ms p=0.038 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 229.37ms (± 0.15%) 229.26ms (± 0.17%) -0.10ms (- 0.05%) 227.91ms 234.74ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 231.66ms (± 0.17%) 231.70ms (± 0.17%) ~ 230.09ms 235.03ms p=0.545 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 231.62ms (± 0.19%) 231.64ms (± 0.19%) ~ 229.70ms 235.38ms p=0.396 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,471k (± 0.01%) 297,012k (± 0.01%) +1,540k (+ 0.52%) 296,996k 297,054k p=0.005 n=6
Parse Time 2.65s (± 0.19%) 2.70s (± 0.33%) +0.05s (+ 2.02%) 2.69s 2.71s p=0.004 n=6
Bind Time 0.82s (± 0.00%) 0.83s (± 0.62%) +0.01s (+ 0.81%) 0.82s 0.83s p=0.025 n=6
Check Time 8.16s (± 0.42%) 8.14s (± 0.50%) ~ 8.09s 8.21s p=0.333 n=6
Emit Time 7.09s (± 0.25%) 7.09s (± 0.36%) ~ 7.05s 7.12s p=0.929 n=6
Total Time 18.73s (± 0.22%) 18.76s (± 0.35%) ~ 18.66s 18.86s p=0.260 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 191,512k (± 0.03%) 192,506k (± 1.23%) ~ 191,507k 197,337k p=0.378 n=6
Parse Time 1.35s (± 0.86%) 1.35s (± 0.98%) ~ 1.33s 1.37s p=0.503 n=6
Bind Time 0.72s (± 0.00%) 0.72s (± 0.00%) ~ 0.72s 0.72s p=1.000 n=6
Check Time 9.26s (± 0.50%) 9.29s (± 0.44%) ~ 9.23s 9.35s p=0.571 n=6
Emit Time 2.61s (± 0.67%) 2.62s (± 0.56%) ~ 2.60s 2.64s p=0.684 n=6
Total Time 13.95s (± 0.22%) 13.98s (± 0.31%) ~ 13.93s 14.04s p=0.686 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,398k (± 0.01%) 347,413k (± 0.01%) ~ 347,386k 347,438k p=0.378 n=6
Parse Time 2.46s (± 0.44%) 2.46s (± 0.26%) ~ 2.45s 2.47s p=0.787 n=6
Bind Time 0.92s (± 0.59%) 0.93s (± 0.56%) ~ 0.92s 0.93s p=0.640 n=6
Check Time 6.89s (± 0.15%) 6.88s (± 0.40%) ~ 6.83s 6.90s p=0.681 n=6
Emit Time 4.06s (± 0.29%) 4.05s (± 0.42%) ~ 4.03s 4.08s p=0.402 n=6
Total Time 14.33s (± 0.12%) 14.31s (± 0.24%) ~ 14.25s 14.34s p=0.459 n=6
TFS - node (v18.15.0, x64)
Memory used 302,746k (± 0.00%) 302,743k (± 0.01%) ~ 302,713k 302,768k p=0.810 n=6
Parse Time 1.98s (± 0.99%) 2.01s (± 0.66%) +0.02s (+ 1.26%) 1.99s 2.03s p=0.032 n=6
Bind Time 1.00s (± 0.51%) 1.00s (± 0.98%) ~ 0.99s 1.02s p=0.504 n=6
Check Time 6.30s (± 0.28%) 6.31s (± 0.37%) ~ 6.27s 6.34s p=0.808 n=6
Emit Time 3.59s (± 0.52%) 3.57s (± 0.58%) ~ 3.54s 3.60s p=0.250 n=6
Total Time 12.88s (± 0.16%) 12.89s (± 0.36%) ~ 12.84s 12.96s p=0.572 n=6
material-ui - node (v18.15.0, x64)
Memory used 506,834k (± 0.01%) 511,794k (± 0.00%) +4,961k (+ 0.98%) 511,785k 511,804k p=0.005 n=6
Parse Time 2.59s (± 0.47%) 2.68s (± 0.45%) +0.08s (+ 3.21%) 2.67s 2.70s p=0.004 n=6
Bind Time 0.99s (± 0.83%) 0.99s (± 0.83%) ~ 0.98s 1.00s p=1.000 n=6
Check Time 16.95s (± 0.21%) 16.97s (± 0.43%) ~ 16.89s 17.06s p=1.000 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.53s (± 0.23%) 20.63s (± 0.34%) +0.10s (+ 0.46%) 20.56s 20.72s p=0.029 n=6
xstate - node (v18.15.0, x64)
Memory used 512,850k (± 0.01%) 514,862k (± 0.01%) +2,012k (+ 0.39%) 514,789k 514,953k p=0.005 n=6
Parse Time 3.27s (± 0.25%) 3.38s (± 0.12%) +0.11s (+ 3.31%) 3.38s 3.39s p=0.003 n=6
Bind Time 1.54s (± 0.34%) 1.53s (± 0.34%) ~ 1.53s 1.54s p=0.311 n=6
Check Time 2.83s (± 0.68%) 2.83s (± 0.63%) ~ 2.81s 2.86s p=0.871 n=6
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) ~ 0.07s 0.07s p=1.000 n=6
Total Time 7.72s (± 0.25%) 7.82s (± 0.28%) +0.10s (+ 1.27%) 7.79s 7.85s p=0.005 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,342ms (± 0.45%) 2,353ms (± 0.89%) ~ 2,337ms 2,394ms p=0.423 n=6
Req 2 - geterr 5,425ms (± 1.82%) 5,431ms (± 1.58%) ~ 5,360ms 5,562ms p=0.688 n=6
Req 3 - references 323ms (± 1.01%) 327ms (± 1.04%) ~ 323ms 332ms p=0.148 n=6
Req 4 - navto 276ms (± 1.27%) 277ms (± 1.34%) ~ 271ms 280ms p=0.250 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 87ms (± 5.81%) 90ms (± 6.21%) ~ 83ms 95ms p=0.623 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,467ms (± 0.98%) 2,489ms (± 1.46%) ~ 2,446ms 2,527ms p=0.296 n=6
Req 2 - geterr 4,161ms (± 1.95%) 4,123ms (± 1.43%) ~ 4,088ms 4,241ms p=1.000 n=6
Req 3 - references 336ms (± 1.15%) 339ms (± 1.47%) ~ 332ms 344ms p=0.513 n=6
Req 4 - navto 285ms (± 1.12%) 284ms (± 0.39%) ~ 283ms 286ms p=0.681 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 83ms (± 6.35%) 85ms (± 7.28%) ~ 76ms 90ms p=0.413 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,612ms (± 0.46%) 2,646ms (± 0.50%) +34ms (+ 1.31%) 2,621ms 2,658ms p=0.008 n=6
Req 2 - geterr 1,740ms (± 1.70%) 1,724ms (± 2.26%) ~ 1,662ms 1,761ms p=0.471 n=6
Req 3 - references 116ms (± 8.71%) 114ms (± 8.83%) ~ 101ms 123ms p=0.618 n=6
Req 4 - navto 365ms (± 0.24%) 365ms (± 0.56%) ~ 363ms 369ms p=1.000 n=6
Req 5 - completionInfo count 2,073 (± 0.00%) 2,073 (± 0.00%) ~ 2,073 2,073 p=1.000 n=6
Req 5 - completionInfo 312ms (± 1.65%) 308ms (± 1.14%) ~ 302ms 311ms p=0.053 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@microsoft microsoft deleted a comment from typescript-bot Jan 9, 2024
@microsoft microsoft deleted a comment from typescript-bot Jan 9, 2024
@microsoft microsoft deleted a comment from typescript-bot Jan 9, 2024
@microsoft microsoft deleted a comment from typescript-bot Jan 9, 2024
@andrewbranch
Copy link
Member Author

@typescript-bot perf test
@typescript-bot perf test public

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2024 •
edited
Loading

Heya @andrewbranch, I've started to run the public perf test suite on this PR at 599f1ba. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2024 •
edited
Loading

Heya @andrewbranch, I've started to run the regular perf test suite on this PR at 599f1ba. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
self-build-src - node (v20.5.1, x64)
Memory used 2,672,387k (± 2.84%) 2,657,069k (± 5.34%) ~ 2,574,048k 2,921,287k p=0.810 n=6
Parse Time 5.04s (± 1.33%) 5.02s (± 1.05%) ~ 4.95s 5.08s p=0.689 n=6
Bind Time 1.98s (± 0.52%) 1.99s (± 1.16%) ~ 1.96s 2.02s p=0.571 n=6
Check Time 31.93s (± 0.32%) 32.07s (± 0.33%) ~ 31.98s 32.25s p=0.092 n=6
Emit Time 2.86s (± 3.48%) 2.83s (± 3.55%) ~ 2.69s 2.94s p=0.936 n=6
Total Time 41.83s (± 0.47%) 41.91s (± 0.30%) ~ 41.76s 42.08s p=0.423 n=6
self-compiler - node (v20.5.1, x64)
Memory used 418,895k (± 0.01%) 419,047k (± 0.01%) +152k (+ 0.04%) 418,984k 419,144k p=0.005 n=6
Parse Time 2.88s (± 0.42%) 2.88s (± 0.41%) ~ 2.87s 2.90s p=0.933 n=6
Bind Time 1.13s (± 0.46%) 1.13s (± 0.36%) ~ 1.12s 1.13s p=0.114 n=6
Check Time 14.10s (± 0.25%) 14.13s (± 0.23%) ~ 14.08s 14.18s p=0.171 n=6
Emit Time 1.04s (± 0.52%) 1.05s (± 1.47%) ~ 1.04s 1.07s p=1.000 n=6
Total Time 19.15s (± 0.25%) 19.19s (± 0.23%) ~ 19.13s 19.25s p=0.261 n=6
vscode - node (v20.5.1, x64)
Memory used 2,827,989k (± 0.00%) 2,828,105k (± 0.00%) +116k (+ 0.00%) 2,828,079k 2,828,128k p=0.005 n=6
Parse Time 10.73s (± 0.24%) 10.76s (± 0.23%) ~ 10.73s 10.80s p=0.062 n=6
Bind Time 3.43s (± 0.56%) 3.42s (± 0.34%) ~ 3.40s 3.43s p=0.192 n=6
Check Time 56.09s (± 0.49%) 56.32s (± 0.72%) ~ 55.88s 56.89s p=0.378 n=6
Emit Time 16.17s (± 0.63%) 16.21s (± 0.36%) ~ 16.13s 16.30s p=0.520 n=6
Total Time 86.42s (± 0.39%) 86.71s (± 0.50%) ~ 86.32s 87.33s p=0.230 n=6
System info unknown
Hosts
  • node (v20.5.1, x64)
Scenarios
  • self-build-src - node (v20.5.1, x64)
  • self-compiler - node (v20.5.1, x64)
  • vscode - node (v20.5.1, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 153.84ms (± 0.21%) 153.79ms (± 0.23%) -0.05ms (- 0.04%) 152.63ms 159.14ms p=0.017 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 229.34ms (± 0.14%) 229.27ms (± 0.17%) -0.07ms (- 0.03%) 227.94ms 237.04ms p=0.003 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 231.48ms (± 0.18%) 231.76ms (± 0.18%) +0.28ms (+ 0.12%) 230.14ms 236.05ms p=0.000 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 230.81ms (± 0.18%) 230.96ms (± 0.19%) +0.15ms (+ 0.06%) 229.28ms 237.30ms p=0.002 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,481k (± 0.01%) 295,509k (± 0.02%) ~ 295,434k 295,557k p=0.378 n=6
Parse Time 2.65s (± 0.34%) 2.65s (± 0.24%) ~ 2.64s 2.66s p=1.000 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.99%) ~ 0.82s 0.84s p=1.000 n=6
Check Time 8.18s (± 0.34%) 8.16s (± 0.11%) ~ 8.15s 8.17s p=0.285 n=6
Emit Time 7.10s (± 0.21%) 7.11s (± 0.14%) ~ 7.10s 7.12s p=0.216 n=6
Total Time 18.75s (± 0.16%) 18.75s (± 0.10%) ~ 18.72s 18.77s p=0.871 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 193,503k (± 1.55%) 191,558k (± 0.02%) ~ 191,489k 191,588k p=0.810 n=6
Parse Time 1.35s (± 1.11%) 1.34s (± 0.61%) ~ 1.33s 1.35s p=0.271 n=6
Bind Time 0.72s (± 0.00%) 0.72s (± 0.75%) ~ 0.72s 0.73s p=0.071 n=6
Check Time 9.29s (± 0.50%) 9.31s (± 0.29%) ~ 9.26s 9.33s p=0.373 n=6
Emit Time 2.63s (± 0.39%) 2.63s (± 0.77%) ~ 2.61s 2.66s p=0.868 n=6
Total Time 14.00s (± 0.24%) 14.01s (± 0.33%) ~ 13.94s 14.07s p=0.747 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,417k (± 0.01%) 347,430k (± 0.00%) ~ 347,419k 347,457k p=0.173 n=6
Parse Time 2.45s (± 0.33%) 2.47s (± 0.21%) +0.01s (+ 0.54%) 2.46s 2.47s p=0.014 n=6
Bind Time 0.93s (± 0.44%) 0.93s (± 0.56%) ~ 0.92s 0.93s p=0.595 n=6
Check Time 6.89s (± 0.38%) 6.90s (± 0.30%) ~ 6.86s 6.92s p=0.935 n=6
Emit Time 4.05s (± 0.29%) 4.05s (± 0.48%) ~ 4.03s 4.08s p=0.868 n=6
Total Time 14.32s (± 0.23%) 14.34s (± 0.14%) ~ 14.32s 14.37s p=0.418 n=6
TFS - node (v18.15.0, x64)
Memory used 302,758k (± 0.00%) 302,772k (± 0.00%) ~ 302,762k 302,784k p=0.128 n=6
Parse Time 2.01s (± 1.32%) 2.00s (± 0.93%) ~ 1.98s 2.03s p=0.622 n=6
Bind Time 1.01s (± 0.83%) 1.02s (± 1.34%) ~ 1.00s 1.03s p=0.142 n=6
Check Time 6.31s (± 0.54%) 6.29s (± 0.16%) ~ 6.28s 6.31s p=0.517 n=6
Emit Time 3.58s (± 0.48%) 3.58s (± 0.58%) ~ 3.55s 3.61s p=0.627 n=6
Total Time 12.91s (± 0.55%) 12.89s (± 0.23%) ~ 12.86s 12.93s p=0.520 n=6
material-ui - node (v18.15.0, x64)
Memory used 506,853k (± 0.00%) 506,829k (± 0.01%) ~ 506,794k 506,867k p=0.173 n=6
Parse Time 2.59s (± 0.32%) 2.58s (± 0.53%) ~ 2.57s 2.61s p=0.605 n=6
Bind Time 0.98s (± 1.06%) 0.99s (± 0.64%) ~ 0.98s 1.00s p=0.388 n=6
Check Time 16.99s (± 0.64%) 16.97s (± 0.41%) ~ 16.88s 17.08s p=0.574 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.57s (± 0.54%) 20.54s (± 0.36%) ~ 20.45s 20.64s p=0.575 n=6
xstate - node (v18.15.0, x64)
Memory used 512,960k (± 0.01%) 512,941k (± 0.02%) ~ 512,819k 513,053k p=0.689 n=6
Parse Time 3.28s (± 0.27%) 3.28s (± 0.12%) ~ 3.27s 3.28s p=0.787 n=6
Bind Time 1.53s (± 0.34%) 1.54s (± 0.27%) ~ 1.53s 1.54s p=0.112 n=6
Check Time 2.85s (± 0.43%) 2.84s (± 0.48%) ~ 2.82s 2.86s p=0.869 n=6
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) ~ 0.07s 0.07s p=1.000 n=6
Total Time 7.73s (± 0.18%) 7.73s (± 0.18%) ~ 7.71s 7.75s p=1.000 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,358ms (± 1.17%) 2,344ms (± 0.71%) ~ 2,325ms 2,363ms p=0.378 n=6
Req 2 - geterr 5,430ms (± 1.19%) 5,483ms (± 1.17%) ~ 5,419ms 5,550ms p=0.149 n=6
Req 3 - references 324ms (± 0.53%) 325ms (± 0.84%) ~ 322ms 329ms p=1.000 n=6
Req 4 - navto 274ms (± 0.83%) 273ms (± 1.03%) ~ 270ms 277ms p=0.402 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 90ms (± 4.18%) 91ms (± 4.46%) ~ 84ms 95ms p=0.687 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,492ms (± 0.58%) 2,472ms (± 0.94%) ~ 2,438ms 2,498ms p=0.199 n=6
Req 2 - geterr 4,155ms (± 2.16%) 4,166ms (± 1.86%) ~ 4,083ms 4,242ms p=0.471 n=6
Req 3 - references 335ms (± 1.36%) 336ms (± 1.63%) ~ 331ms 342ms p=1.000 n=6
Req 4 - navto 284ms (± 1.19%) 285ms (± 0.98%) ~ 282ms 290ms p=0.514 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 83ms (± 7.22%) 84ms (± 7.82%) ~ 78ms 90ms p=0.859 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,595ms (± 0.80%) 2,598ms (± 0.51%) ~ 2,574ms 2,612ms p=0.810 n=6
Req 2 - geterr 1,700ms (± 1.79%) 1,707ms (± 2.76%) ~ 1,654ms 1,767ms p=1.000 n=6
Req 3 - references 116ms (± 8.75%) 112ms (± 9.51%) ~ 101ms 124ms p=0.744 n=6
Req 4 - navto 366ms (± 0.15%) 366ms (± 0.41%) ~ 364ms 368ms p=0.863 n=6
Req 5 - completionInfo count 2,073 (± 0.00%) 2,073 (± 0.00%) ~ 2,073 2,073 p=1.000 n=6
Req 5 - completionInfo 306ms (± 1.38%) 308ms (± 1.10%) ~ 304ms 313ms p=0.225 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@andrewbranch andrewbranch merged commit 69f2e2a into microsoft:main Jan 16, 2024
19 checks passed
@andrewbranch andrewbranch deleted the feature/55104 branch January 16, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error message for using outdated moduleResolution: node(10)
3 participants
@andrewbranch @typescript-bot @sheetalkamat