Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize/consolidate inlay hint tests #55332

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

MariaSolOs
Copy link
Contributor

To make #55141 easier to test, I first wanted to reorganize the existing test suite into a smaller set of files with more descriptive file names.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 10, 2023
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me though I don't have a strong opinion about the baselines for a feature I didn't write the code for 😄

@MariaSolOs MariaSolOs merged commit 05cb53e into microsoft:main Aug 14, 2023
17 of 18 checks passed
@MariaSolOs MariaSolOs deleted the inlay-hints-tests branch August 14, 2023 21:21
@jakebailey
Copy link
Member

This got merged without the tests passing, so main is currently broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants