Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra tests for recursive conditional types #54030

Merged

Conversation

Andarist
Copy link
Contributor

closes #43877

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Apr 26, 2023
// @lib: esnext
// @noEmit: true

// repro from https://github.com/microsoft/TypeScript/issues/43877
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was fixed by #46429

MaybeMergePrivateSuperSpec<T["privateExtends"]>
>;

// repro from https://github.com/microsoft/TypeScript/issues/43877#issuecomment-866146516
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wasn't fixed by #46429 , later on it started to loop infinitely (I think?) and that was fixed by #46599

@sandersn sandersn requested a review from weswigham May 8, 2023 23:58
@weswigham weswigham merged commit fefcb81 into microsoft:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Breaking change: Depth limit now hit for some types in 4.3
3 participants