Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set package.json minimum to Node 12.20 #53183

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Set package.json minimum to Node 12.20 #53183

merged 2 commits into from
Mar 9, 2023

Conversation

jakebailey
Copy link
Member

Previously we said 5.0 was going to be Node 10, and that's what's currently documented (though with a note that we may change it to something else https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes#typescript-50), but it seems like 12 is probably a better idea.

This might be something we want to backport so it's in 5.0 as a "breaking" change.

And maybe, it should be 12.20 to give us the ability to use ESM? But, that could be on main later.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 9, 2023
@DanielRosenwasser
Copy link
Member

I think it's now or never. Let's get it in for 5.0, and if we run into issues we can consider a patch.

@typescript-bot cherry-pick this to release-5.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 9, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-5.0 on this PR at d7b4c26. You can monitor the build here.

@DanielRosenwasser
Copy link
Member

Ugh - right, forgot it doesn't say 12.20. Let's go with that. I just canceled that cherry-pick.

@jakebailey jakebailey changed the title Set package.json minimum to Node 12 Set package.json minimum to Node 12.20 Mar 9, 2023
@jakebailey
Copy link
Member Author

Switched to 12.20, and I've also updated the breaking changes page to finalize this.

@jakebailey
Copy link
Member Author

@typescript-bot cherry-pick this to release-5.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 9, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the task to cherry-pick this into release-5.0 on this PR at a05822c. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Mar 9, 2023
Merged
@typescript-bot
Copy link
Collaborator

Hey @jakebailey, I've opened #53186 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 9, 2023
@jakebailey @typescript-bot
Cherry-pick PR microsoft#53183 into release-5.0
818eaf7 
Component commits:
d7b4c26 Set package.json minimum to Node 12

a05822c Bump to v12.20 and update lock
@jakebailey jakebailey added this to the TypeScript 5.0.2 milestone Mar 9, 2023
@fatcerberus
Copy link

"node": ">=4.2.0"

Can any semi-recent version of TS actually even run on Node 4? 😆

@jakebailey
Copy link
Member Author

No, absolutely not!

DanielRosenwasser pushed a commit that referenced this pull request Mar 9, 2023
@jakebailey
🤖 Pick PR #53183 (Set package.json minimum to Node 12...) into releas…
f7f44da 
…e-5.0 (#53186)

Co-authored-by: Jake Bailey <[email protected]>
@jakebailey jakebailey merged commit 7898cc1 into microsoft:main Mar 9, 2023
@jakebailey jakebailey deleted the package-json-node branch March 9, 2023 22:27
drivron pushed a commit to scenari/typescript that referenced this pull request Sep 14, 2023
@jakebailey
🤖 Pick PR microsoft#53183 (Set package.json minimum to Node 12...) in…
e990513 
…to release-5.0 (microsoft#53186)

Co-authored-by: Jake Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
TypeScript 5.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jakebailey @DanielRosenwasser @typescript-bot @fatcerberus