[WIP] [Experiment] feat(1534): Add "sealed" key word to mark some public/protected methods not be overriden #45021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The TypeScript team hasn't accepted the linked issue #1534. If you can get it accepted, this PR will have a better chance of being reviewed. |
typescript-bot
added
the
For Uncommitted Bug
|
You can utilize a "draft PR" feature of GitHub! |
a-tarasyuk
force-pushed
the
feat/1534
branch
from
68818f1 to
fd3f9d8
Compare
a-tarasyuk
force-pushed
the
feat/1534
branch
2 times, most recently
from
0674dca to
98fe765
Compare
a-tarasyuk
force-pushed
the
feat/1534
branch
from
a1102c9 to
143258c
Compare
a-tarasyuk
force-pushed
the
feat/1534
branch
2 times, most recently
from
187b69f to
75033be
Compare
a-tarasyuk
force-pushed
the
feat/1534
branch
from
75033be to
c7885ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft/proposal PR for adding a
sealedmodifier to prevent property/method overriding in child classes.Any feedback to make a clear proposal/behavior is appreciated.
sealedcannot be used withprivatesealedcannot be used with abstract declarationssealedcannot be used with constructor declarationpublic/protectedmethods/propertiesmarkedsealedcannot be overridden in child classesFixes #1534