Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compilerOption): add instantiationDepthLimit and instantiationCountLimit #44997

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(compilerOption): add instantiationDepthLimit and instantiationCountLimit #44997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81ebc4a
feat(compilerOption): add instantiationDepthLimit and instantiationCo…
jjangga0214 Jul 13, 2021
02dbb75
chore(compilerOption): recomment
jjangga0214 Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16259,8 +16259,8 @@ namespace ts {
if (!couldContainTypeVariables(type)) {
return type;
}
if (instantiationDepth === 50 || instantiationCount >= 5000000) {
// We have reached 50 recursive type instantiations and there is a very high likelyhood we're dealing
if (instantiationDepth >= compilerOptions.instantiationDepthLimit || instantiationCount >= compilerOptions.instantiationCountLimit) {
// We have reached the limitation threshold of recursive type instantiations and there is a very high likelyhood we're dealing
// with a combination of infinite generic types that perpetually generate new type identities. We stop
// the recursion here by yielding the error type.
tracing?.instant(tracing.Phase.CheckTypes, "instantiateType_DepthLimit", { typeId: type.id, instantiationDepth, instantiationCount });
Expand Down
Loading